Issue 238783004: Revert 263791 "Remove dependency of NaCl untarred toolchain from..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 238783004: Revert 263791 "Remove dependency of NaCl untarred toolchain from..." (Closed)

Created:
6 years, 8 months ago by binji

Modified:
6 years, 8 months ago

Reviewers:
David Yen

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 263791 "Remove dependency of NaCl untarred toolchain from..." This broke the win-sdk-multi bot: http://build.chromium.org/p/client.nacl.sdk/builders/windows-sdk-multi/builds/5486/steps/Run%20unittests/logs/stdio > Remove dependency of NaCl untarred toolchain from NaCl SDK Tests. > > Nothing on the chromium side should depend on the untarred toolchains > within the NaCl tree. Have NaCl SDK tests untar its own copy of what it > needs before proceeding. > > R=binji@chromium.org > > Review URL: https://codereview.chromium.org/237883002 TBR=dyen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263904

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -63 lines)			Patch
M	trunk/src/native_client_sdk/src/test_all.py	View	2 chunks	+3 lines, -53 lines	0 comments	Download
M	trunk/src/native_client_sdk/src/tools/lib/tests/get_shared_deps_test.py	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	trunk/src/native_client_sdk/src/tools/tests/create_nmf_test.py	View	2 chunks	+4 lines, -5 lines	0 comments	Download

Total messages: 3 (0 generated)

Message was sent while issue was closed.

lgtm