Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 238783003: Merge 262846 "Revert 255617, due to it not tracking use of the link doctor page." (Closed)

Created:
6 years, 8 months ago by mmenke
Modified:
6 years, 8 months ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Merge 262846 "Revert 255617, due to it not tracking use of the link doctor page." > Revert 255617, due to it not tracking use of the link doctor page properly. > > Not reverting the string changes, because the new strings work with the old file, > and we've passed string freeze. > > > Switch to using the new Link Doctor API. > > > > The new API allows Link Doctor results to be integrated into Chrome's > > own error pages. > > BUG=64832, 359131 > TBR=mmenke@chromium.org > > Originally Landed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255617 > > Review URL: https://codereview.chromium.org/228803002 TBR=mmenke@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263851

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+474 lines, -1588 lines) Patch
M chrome/browser/chromeos/offline/offline_load_page.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/errorpage_browsertest.cc View 18 chunks +68 lines, -212 lines 0 comments Download
M chrome/browser/google/google_util.h View 2 chunks +3 lines, -9 lines 0 comments Download
M chrome/browser/google/google_util.cc View 3 chunks +19 lines, -43 lines 0 comments Download
M chrome/browser/net/dns_probe_browsertest.cc View 26 chunks +121 lines, -144 lines 0 comments Download
M chrome/browser/net/url_request_mock_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 3 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/alternate_error_tab_observer.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/ui/alternate_error_tab_observer.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/ui/navigation_correction_tab_observer.h View 1 chunk +0 lines, -62 lines 0 comments Download
D chrome/browser/ui/navigation_correction_tab_observer.cc View 1 chunk +0 lines, -99 lines 0 comments Download
M chrome/browser/ui/tab_helpers.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/localized_error.h View 3 chunks +2 lines, -24 lines 0 comments Download
M chrome/common/localized_error.cc View 8 chunks +16 lines, -48 lines 0 comments Download
M chrome/common/render_messages.h View 1 chunk +3 lines, -8 lines 0 comments Download
M chrome/renderer/net/net_error_helper.h View 2 chunks +9 lines, -18 lines 0 comments Download
M chrome/renderer/net/net_error_helper.cc View 9 chunks +24 lines, -56 lines 0 comments Download
M chrome/renderer/net/net_error_helper_core.h View 6 chunks +11 lines, -30 lines 0 comments Download
M chrome/renderer/net/net_error_helper_core.cc View 11 chunks +83 lines, -263 lines 0 comments Download
M chrome/renderer/net/net_error_helper_core_unittest.cc View 32 chunks +95 lines, -448 lines 0 comments Download
M chrome/renderer/resources/neterror.css View 8 chunks +11 lines, -58 lines 0 comments Download
M chrome/renderer/resources/neterror.html View 2 chunks +5 lines, -20 lines 0 comments Download
M chrome/renderer/resources/neterror.js View 1 chunk +0 lines, -7 lines 0 comments Download
A + chrome/test/data/mock-link-doctor.html View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/mock-link-doctor.json View 1 chunk +0 lines, -31 lines 0 comments Download
A + chrome/test/data/mock-link-doctor.html.mock-http-headers View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/mock-link-doctor.json.mock-http-headers View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
mmenke
6 years, 8 months ago (2014-04-15 15:00:24 UTC) #1
mmenke
6 years, 8 months ago (2014-04-15 15:02:24 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 manually as r263851 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698