Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3154)

Unified Diff: blimp/client/core/context/BUILD.gn

Issue 2387813002: Move session into //blimp/client/app and update GN files. (Closed)
Patch Set: Rebased Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « blimp/client/core/contents/BUILD.gn ('k') | blimp/client/core/geolocation/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/client/core/context/BUILD.gn
diff --git a/blimp/client/core/context/BUILD.gn b/blimp/client/core/context/BUILD.gn
index 5b767d7b68f6fc1656503659b6920a3cf3c8da97..737e8db137e3c2c4f02202e342cf12cfd173427f 100644
--- a/blimp/client/core/context/BUILD.gn
+++ b/blimp/client/core/context/BUILD.gn
@@ -8,6 +8,13 @@ if (is_android) {
}
source_set("context") {
+ visibility = [
+ ":unit_tests",
+ "//blimp/client/app:session", # TODO(nyquist): Remove this. See crbug/651964.
+ "//blimp/client/core",
+ "//blimp/engine:browser_tests", # TODO(nyquist): Remove this. See crbug/653789.
+ ]
+
sources = [
"blimp_client_context_impl.cc",
"blimp_client_context_impl.h",
@@ -71,6 +78,8 @@ source_set("dummy") {
}
source_set("unit_tests") {
+ visibility = [ "//blimp/client/core:unit_tests" ]
+
testonly = true
sources = [
@@ -87,7 +96,7 @@ source_set("unit_tests") {
if (is_android) {
android_library("context_java") {
- visibility = [ "//blimp/client/*" ]
+ visibility = [ "//blimp/client/core/*" ]
java_files = [ "android/java/src/org/chromium/blimp/core/BlimpClientContextImpl.java" ]
@@ -104,7 +113,7 @@ if (is_android) {
}
android_library("dummy_context_java") {
- visibility = [ "//blimp/client/*" ]
+ visibility = [ "//blimp/client/core/*" ]
java_files = [ "android/java/src/org/chromium/blimp/core/DummyBlimpClientContext.java" ]
« no previous file with comments | « blimp/client/core/contents/BUILD.gn ('k') | blimp/client/core/geolocation/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698