Issue 2387803002: Use SkPaintImageFilter of a bitmap to implement box reflection masks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2387803002: Use SkPaintImageFilter of a bitmap to implement box reflection masks. (Closed)

Created:
4 years, 2 months ago by chrishtr

Modified:
4 years, 2 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2840

Project:
chromium

Visibility:
Public.

Use SkPaintImageFilter of a bitmap to implement box reflection masks. BUG=648055 Review-Url: https://codereview.chromium.org/2379453002 Cr-Commit-Position: refs/heads/master@{#421875} (cherry picked from commit 9132e7071ba56be31591b2a9b5b31e6fe0adc3b1) Committed: https://chromium.googlesource.com/chromium/src/+/42be9ab0db63120d683fa7d3f34263fc7b3dc37d

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -2 lines)			Patch
M	third_party/WebKit/LayoutTests/TestExpectations	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/platform/graphics/BoxReflection.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp	View	2 chunks	+14 lines, -1 line	0 comments	Download

Total messages: 2 (1 generated)

chrishtr

4 years, 2 months ago (2016-09-30 21:20:11 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
42be9ab0db63120d683fa7d3f34263fc7b3dc37d.