Whitelist for metricsPrivate.getIsCrashReportingEnabled

chrome/common/extensions/api/_api_features.json

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This features file defines extension APIs implemented under src/chrome.
 // See chrome/common/extensions/api/_features.md to understand this file, as
 // well as feature.h, simple_feature.h, and base_feature_provider.h.
 //
 // Note that specifying "web_page", "blessed_web_page", or "all" as a context
 // type will require manually updating chrome/renderer/resources/dispatcher.cc.
@@ skipping 566 matching lines @@
   "mediaGalleries": {
     "dependencies": ["permission:mediaGalleries"],
     "contexts": ["blessed_extension"]
   },
   "mediaPlayerPrivate": {
     "dependencies": ["permission:mediaPlayerPrivate"],
     "contexts": ["blessed_extension"]
   },
   "metricsPrivate": [{
     "dependencies": ["permission:metricsPrivate"],
-    "contexts": ["blessed_extension"]
+    "contexts": ["blessed_extension"],
+    "default_parent": true

[Ilya Sherman, 2016/10/03 21:11:10]

What does default_parent mean?

[michaelpg, 2016/10/04 19:21:33]

metricsPrivate is a "complex" feature (it's an array of 2 objects). To use
metricsPrivate as a parent (automatically done for metricsPrivate.foo, as below)
we have to specify which of these two objects its children should inherit from.

See:
https://cs.chromium.org/chromium/src/chrome/common/extensions/api/_features.m...

   }, {
     "channel": "trunk",
     "contexts": ["webui"],
     "matches": [
       "chrome://md-settings/*",
       "chrome://settings/*",
       "chrome://settings-frame/*"
     ]
   }],
+  "metricsPrivate.getIsCrashReportingEnabled": {
+    "whitelist": [

[Devlin, 2016/10/01 01:01:58]

Can you clarify what the intent here is?  Right now, this basically just
prevents webui from using this function, while allowing everything else. 
Additionally, any new extensions will need to be whitelisted both here and in
_permissions_features.json in order to use it.  Is that the desired behavior?

[michaelpg, 2016/10/01 01:47:09]

webui doesn't use it; if it does we'd do the same thing for chrome URLs
The desired behavior is:

1. New extensions which need to use chrome.metricsPrivate just whitelist
themselves in _permissions_features.json, same as today
2. New extensions which specifically want to use
chrome.metricsPrivate.getIsCrashReportingEnabled() wonder why the function
doesn't exist, find this _api_features.json entry, read the comment, and either:
   a) Follow instructions, asking a metrics owner for a review
   b) Ignore the comment and whitelist themselves (hopefully a reviewer would
notice; to that end, maybe better to put a comment at the end of the list?)

Basically the metrics ppl are concerned about misuse of this function and want
people to include them in reviews before using the function in new places.

[Devlin, 2016/10/01 02:03:44]

This is a pretty monstrous list.  Let's see if we can't narrow it down a bit. 
I'll follow up with you offline.

[Ilya Sherman, 2016/10/03 21:11:10]

+1 to narrowing if possible.  I bet most of these extensions don't rely on this
API currently -- IIRC, only ~5 extensions actually use it.

[michaelpg, 2016/10/04 00:53:08]

Done.

+      // This function inherits the extension restrictions of metricsPrivate,
+      // but also requires whitelisting. New uses of this function should get
+      // metrics_private OWNERS approval of the usage before adding entries

[michaelpg, 2016/09/30 21:10:34]

or //tools/metrics/OWNERS?

[Ilya Sherman, 2016/10/03 21:11:10]

Yes, the intent is for //tools/metrics/OWNERS to take a look at any new uses of
this API =)

[michaelpg, 2016/10/04 00:53:08]

Done.

+      // below. See crbug.com/374199.
+      "A948368FC53BE437A55FEB414106E207925482F5",  // File manager
+      "2FC374607C2DF285634B67C64A2E356C607091C3",  // Quickoffice
+      "3727DD3E564B6055387425027AD74C58784ACC15",  // Quickoffice internal
+      "12E618C3C6E97495AAECF2AC12DEB082353241C6",  // QO component extension
+      "3727DD3E564B6055387425027AD74C58784ACC15",  // Editor
+      "C41AD9DCD670210295614257EF8C9945AD68D86E",  // Google Now
+      "6EEEA7775E79C735E4BA1F24DBB191BDACB1262C",  // RU-NTP
+      "7AE714FFD394E073F0294CFA134C9F91DB5FBAA4",  // CCD Development
+      "C7DA3A55C2355F994D3FDDAD120B426A0DF63843",  // CCD Testing
+      "75E3CFFFC530582C583E4690EF97C70B9C8423B7",  // CCD Release
+      "D5736E4B5CF695CB93A2FB57E4FDC6E5AFAB6FE2",  // http://crbug.com/312900.
+      "D57DE394F36DC1C3220E7604C575D29C51A6C495",  // http://crbug.com/319444.
+      "3F65507A3B39259B38C8173C6FFA3D12DF64CCE9",  // http://crbug.com/371562.
+      "06BE211D5F014BAB34BC22D9DDA09C63A81D828E",  // Official XKB virtual kbd
+      "CFBF7EE448FA48960FFDA7CEB30F7A21B26AA981",  // Official m17n virtual kbd
+      "B9EF10DDFEA11EF77873CC5009809E5037FC4C7A",  // Google input tools
+      "7D7A4B147FE39908A5AF13F85E38989C54BBE41C",  // http://crbug.com/374955
+      "0EEDFC0EED87871237213F34EBC7B4982A195C95",  // http://crbug.com/374955
+      "D2DAA9362153E8A5E3CF593E6DF4666421ABAD21",  // http://crbug.com/374965
+      "D7986543275120831B39EF28D1327552FC343960",  // http://crbug.com/378067
+      "A291B26E088FA6BA53FFD72F0916F06EBA7C585A",  // http://crbug.com/378067
+      "62CCAAD339E6451BBF97C4BBDF758E934A05AD0B",  // Hotword triggering
+      "07BD6A765FFC289FF755D7CAB2893A40EC337FEC",  // http://crbug.com/456214
+      "896B85CC7E913E11C34892C1425A093C0701D386",  // http://crbug.com/456214
+      "11A01C82EF355E674E4F9728A801F5C3CB40D83F",  // http://crbug.com/456214
+      "F410C88469990EE7947450311D24B8AF2ADB2595",  // http://crbug.com/456214
+      "9E527CDA9D7C50844E8A5DB964A54A640AE48F98",  // Chrome Remote Desktop(CRD)
+      "DF52618D0B040D8A054D8348D2E84DDEEE5974E7",  // CRD QA
+      "269D721F163E587BC53C6F83553BF9CE2BB143CD",  // CRD QA Backup
+      "6B55A5329E3F1F30F6032BDB20B2EB4378DBF767",  // CRD QA v2
+      "C449A798C495E6CF7D6AF10162113D564E67AD12",  // CRD Dogfood
+      "01E9FFA9A8F3C18271FE91BEE46207F3B81755CC",  // Pre-release CRD
+      "97B23E01B2AA064E8332EE43A7A85C628AADC3F2",  // Sample app_remoting app.
+      "226CF815E39A363090A1E547D53063472B8279FA",  // http://crbug.com/574889
+      "C17CD9E6868D7B9C67926E0EC612EA25C768418F",  // http://crbug.com/504940
+      "A45DABDB47A31CC812E5490AB748C7D05E2D32E9",  // http://crbug.com/504940
+      "BFEE2E3B80BE21A645E63E9346DFC383E7CB3BDA",  // http://crbug.com/504940
+      "63ED55E43214C211F82122ED56407FF1A807F2A3",  // http://crbug.com/504940
+      // TODO (ntang) Remove the following 2 hashes by 12/31/2017.
+      "B620CF4203315F9F2E046EDED22C7571A935958D",  // http://crbug.com/510270
+      "B206D8716769728278D2D300349C6CB7D7DE2EF9",  // http://crbug.com/510270
+      "2B6C6A4A5940017146F3E58B7F90116206E84685",  // http://crbug.com/642141
+      "B6C2EFAB3EC3BF6EF03701408B6B09A67B2D0069",  // http://crbug.com/642141
+      "96FF2FFA5C9173C76D47184B3E86D267B37781DE",  // http://crbug.com/642141
+      "0136FCB13DB29FD5CD442F56E59E53B61F1DF96F"   // http://crbug.com/642141
+    ]
+  },
   "mdns": {
     "dependencies": ["permission:mdns"],
     "contexts": ["blessed_extension"]
   },
   "mimeHandlerViewGuestInternal": {
     "internal": true,
     "contexts": "all",
     "channel": "stable",
     "matches": ["<all_urls>"]
   },
@@ skipping 224 matching lines @@
     "internal": true,
     "channel": "stable",
     "dependencies": ["permission:webview"],
     "contexts": ["blessed_extension"]
   },
   "windows": {
     "dependencies": ["api:tabs"],
     "contexts": ["blessed_extension"]
   }
 }