Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Unified Diff: chromeos/settings/timezone_settings_unittest.cc

Issue 2387783002: Remove stl_util's deletion functions from chromeos/. (Closed)
Patch Set: armansito Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/settings/timezone_settings_helper.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/settings/timezone_settings_unittest.cc
diff --git a/chromeos/settings/timezone_settings_unittest.cc b/chromeos/settings/timezone_settings_unittest.cc
index 3c9e129ac8fd0a30ea4bfe07d946fc6b945123bb..2e23ae172661d3474c9a85d16887a2b4cbd8f259 100644
--- a/chromeos/settings/timezone_settings_unittest.cc
+++ b/chromeos/settings/timezone_settings_unittest.cc
@@ -4,7 +4,7 @@
#include <memory>
-#include "base/stl_util.h"
+#include "base/memory/ptr_util.h"
#include "chromeos/settings/timezone_settings_helper.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/icu/source/common/unicode/unistr.h"
@@ -36,14 +36,13 @@ class KnownTimeZoneTest : public testing::Test {
void SetUp() override {
for (const char* id : kTimeZones) {
- timezones_.push_back(TimeZone::createTimeZone(UnicodeString(id)));
+ timezones_.push_back(
+ base::WrapUnique(TimeZone::createTimeZone(UnicodeString(id))));
}
}
- void TearDown() override { base::STLDeleteElements(&timezones_); }
-
protected:
- std::vector<TimeZone*> timezones_;
+ std::vector<std::unique_ptr<TimeZone>> timezones_;
};
TEST_F(KnownTimeZoneTest, IdMatch) {
« no previous file with comments | « chromeos/settings/timezone_settings_helper.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698