Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 2387783002: Remove stl_util's deletion functions from chromeos/. (Closed)

Created:
4 years, 2 months ago by Avi (use Gerrit)
Modified:
4 years, 2 months ago
Reviewers:
armansito, Daniel Erat
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org, hashimoto+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove stl_util's deletion functions from chromeos/. BUG=555865 Committed: https://crrev.com/dfcc90f16c93ba4448f0547d9856e3ca99167a89 Cr-Commit-Position: refs/heads/master@{#422979}

Patch Set 1 #

Patch Set 2 : fixes #

Patch Set 3 : fixes #

Patch Set 4 : fix #

Total comments: 2

Patch Set 5 : const #

Total comments: 2

Patch Set 6 : armansito #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -84 lines) Patch
M chrome/browser/chromeos/system/timezone_util.cc View 1 2 3 4 5 1 chunk +2 lines, -4 lines 0 comments Download
M chromeos/dbus/fake_shill_profile_client.h View 3 chunks +2 lines, -3 lines 0 comments Download
M chromeos/dbus/fake_shill_profile_client.cc View 5 chunks +14 lines, -20 lines 0 comments Download
M chromeos/network/managed_network_configuration_handler.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M chromeos/network/managed_network_configuration_handler_impl.cc View 1 2 7 chunks +10 lines, -15 lines 0 comments Download
M chromeos/network/policy_applicator.h View 1 chunk +2 lines, -1 line 0 comments Download
M chromeos/network/policy_applicator.cc View 1 2 3 4 5 3 chunks +6 lines, -7 lines 0 comments Download
M chromeos/network/policy_util.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chromeos/network/policy_util.cc View 1 4 chunks +6 lines, -7 lines 0 comments Download
M chromeos/settings/timezone_settings.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M chromeos/settings/timezone_settings.cc View 1 2 5 chunks +7 lines, -7 lines 0 comments Download
M chromeos/settings/timezone_settings_helper.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M chromeos/settings/timezone_settings_helper.cc View 1 2 chunks +8 lines, -8 lines 0 comments Download
M chromeos/settings/timezone_settings_unittest.cc View 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 35 (27 generated)
Avi (use Gerrit)
armansito: chromeos/network derat: all the rest
4 years, 2 months ago (2016-09-30 21:26:44 UTC) #16
Daniel Erat
lgtm https://codereview.chromium.org/2387783002/diff/60001/chrome/browser/chromeos/system/timezone_util.cc File chrome/browser/chromeos/system/timezone_util.cc (right): https://codereview.chromium.org/2387783002/diff/60001/chrome/browser/chromeos/system/timezone_util.cc#newcode149 chrome/browser/chromeos/system/timezone_util.cc:149: auto& timezones = can this remain const?
4 years, 2 months ago (2016-09-30 22:38:04 UTC) #19
Avi (use Gerrit)
https://codereview.chromium.org/2387783002/diff/60001/chrome/browser/chromeos/system/timezone_util.cc File chrome/browser/chromeos/system/timezone_util.cc (right): https://codereview.chromium.org/2387783002/diff/60001/chrome/browser/chromeos/system/timezone_util.cc#newcode149 chrome/browser/chromeos/system/timezone_util.cc:149: auto& timezones = On 2016/09/30 22:38:04, Daniel Erat wrote: ...
4 years, 2 months ago (2016-10-01 21:51:06 UTC) #22
armansito
lgtm https://codereview.chromium.org/2387783002/diff/80001/chromeos/network/policy_applicator.cc File chromeos/network/policy_applicator.cc (right): https://codereview.chromium.org/2387783002/diff/80001/chromeos/network/policy_applicator.cc#newcode56 chromeos/network/policy_applicator.cc:56: for (auto it = all_policies.begin(); it != all_policies.end(); ...
4 years, 2 months ago (2016-10-04 20:30:26 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2387783002/100001
4 years, 2 months ago (2016-10-04 22:03:11 UTC) #31
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 2 months ago (2016-10-04 22:49:26 UTC) #32
commit-bot: I haz the power
Patchset 6 (id:??) landed as https://crrev.com/dfcc90f16c93ba4448f0547d9856e3ca99167a89 Cr-Commit-Position: refs/heads/master@{#422979}
4 years, 2 months ago (2016-10-04 22:52:47 UTC) #34
Avi (use Gerrit)
4 years, 2 months ago (2016-10-09 18:14:53 UTC) #35
Message was sent while issue was closed.
https://codereview.chromium.org/2387783002/diff/80001/chromeos/network/policy...
File chromeos/network/policy_applicator.cc (right):

https://codereview.chromium.org/2387783002/diff/80001/chromeos/network/policy...
chromeos/network/policy_applicator.cc:56: for (auto it = all_policies.begin();
it != all_policies.end(); ++it) {
On 2016/10/04 20:30:26, armansito wrote:
> nit: "for (const auto& it : all_policies)" should work too.

Done.

Powered by Google App Engine
This is Rietveld 408576698