Add initial postprocess unit test thingy.

recipe_engine/checker.py

+# Copyright 2014 The LUCI Authors. All rights reserved.
+# Use of this source code is governed under the Apache License, Version 2.0
+# that can be found in the LICENSE file.
+
+"""Provides simulator test coverage for individual recipes."""
+
+import ast
+import copy
+import inspect
+import re
+import itertools
+
+from collections import OrderedDict, namedtuple, deque, defaultdict
+
+from . import env
+import astunparse
+import expect_tests
+
+
+class _resolved(ast.AST):
+  """_resolved is a fake AST node which represents a resolved sub-expression.
+  It's used by _checkTransformer to replace portions of its AST with their
+  resolved equivalents."""
+  def __init__(self, representation, value):
+    super(_resolved, self).__init__()
+    self.representation = representation
+    self.value = value
+
+
+class _checkTransformer(ast.NodeTransformer):
+  """_checkTransformer is an ast NodeTransformer which extracts the helpful
+  subexpressions from a python expression (specificially, from an invocation of
+  the Checker). These subexpressions will be printed along with the check's
+  source code statement to provide context for the failed check.
+
+  It knows the following transformations:
+    * all python identifiers will be resolved to their local variable meaning.
+    * `___ in <instance of dict>` will cause dict.keys() to be printed in lieu
+      of the entire dictionary.
+    * `a[b][c]` will cause `a[b]` and `a[b][c]` to be printed (for an arbitrary
+      level of recursion)
+
+  The transformed ast is NOT a valid python AST... In particular, every reduced
+  subexpression will be a _resolved() where the `representation` is the code for
+  the subexpression (It could be any valid expression like `foo.bar()`),
+  and the `value` will be the eval'd value for that element.
+
+  In addition to this, there will be a list of _resolved nodes in the
+  transformer's `extra` attribute for additional expressions which should be
+  printed for debugging usefulness, but didn't fit into the ast tree anywhere.
+  """
+
+  def __init__(self, lvars, gvars):
+    self.lvars = lvars
+    self.gvars = gvars
+    self.extras = []
+
+  def visit_Compare(self, node):
+    """Compare nodes occur for all sequences of comparison (`in`, gt, lt, etc.)
+    operators. We only want to match `___ in instanceof(dict)` here, so we
+    restrict this to Compare ops with a single operator which is `In`.

[martiniss, 2016/10/13 22:54:12]

... which is `In` or `not in`?

[iannucci, 2016/10/13 23:05:05]

done

+    """
+    node = self.generic_visit(node)
+
+    if len(node.ops) == 1 and isinstance(node.ops[0], (ast.In, ast.NotIn)):
+      cmps = node.comparators
+      if len(cmps) == 1 and isinstance(cmps[0], _resolved):
+        rslvd = cmps[0]
+        if isinstance(rslvd.value, dict):
+          node = ast.Compare(
+            node.left,
+            node.ops,
+            [_resolved(rslvd.representation+".keys()",
+                      sorted(rslvd.value.keys()))])
+
+    return node
+
+  def visit_Subscript(self, node):
+    """Subscript nodes are anything which is __[__]. We only want to match __[x]
+    here so where the [x] is a regular Index expression (not an elipsis or
+    slice). We only handle cases where x is a constant, or a resolvable variable
+    lookup (so a variable lookup, index, etc.)."""
+    node = self.generic_visit(node)
+
+    if (isinstance(node.slice, ast.Index) and
+        isinstance(node.value, _resolved)):
+      sliceVal = MISSING
+      sliceRepr = ''
+      if isinstance(node.slice.value, _resolved):
+        # (a[b])[c]
+        # will include `a[b]` in the extras.
+        self.extras.append(node.slice.value)
+        sliceVal = node.slice.value.value
+        sliceRepr = node.slice.value.representation
+      elif isinstance(node.slice.value, ast.Num):
+        sliceVal = node.slice.value.n
+        sliceRepr = repr(sliceVal)
+      elif isinstance(node.slice.value, ast.Str):
+        sliceVal = node.slice.value.s
+        sliceRepr = repr(sliceVal)
+      if sliceVal is not MISSING:
+        node = _resolved(
+          '%s[%s]' % (node.value.representation, sliceRepr),
+          node.value.value[sliceVal])
+
+    return node
+
+  def visit_Name(self, node):
+    """Matches a single, simple identifier (e.g. variable).
+
+    This will lookup the variable value from python constants (e.g. True),
+    followed by the frame's local variables, and finally by the frame's global
+    variables.
+    """
+    consts = {'True': True, 'False': False, 'None': None}

[martiniss, 2016/10/13 22:54:12]

O_O I didn't know these kinds of constants are identifiers too?

[iannucci, 2016/10/13 23:05:05]

Yep

+    val = consts.get(
+      node.id, self.lvars.get(
+        node.id, self.gvars.get(
+          node.id, MISSING)))
+    if val is not MISSING:
+      return _resolved(node.id, val)
+    return node
+
+
+def render_user_value(val):
+  """Takes a subexpression user value, and attempts to render it in the most
+  useful way possible.
+
+  Currently this will use render_re for compiled regular expressions, and will
+  fall back to repr() for everything else.
+
+  It should be the goal of this function to return an `eval`able string that
+  would yield the equivalent value in a python interpreter.
+  """
+  if isinstance(val, re._pattern_type):
+    return render_re(val)
+  return repr(val)
+
+
+def render_re(regex):
+  """Renders a repr()-style value for a compiled regular expression."""
+  actual_flags = []
+  if regex.flags:
+    flags = [
+      (re.IGNORECASE, 'IGNORECASE'),
+      (re.LOCALE, 'LOCALE'),
+      (re.UNICODE, 'UNICODE'),
+      (re.MULTILINE, 'MULTILINE'),
+      (re.DOTALL, 'DOTALL'),
+      (re.VERBOSE, 'VERBOSE'),
+    ]
+    for val, name in flags:
+      if regex.flags & val:
+        actual_flags.append(name)
+  if actual_flags:
+    return 're.compile(%r, %s)' % (regex.pattern, '|'.join(actual_flags))
+  else:
+    return 're.compile(%r)' % regex.pattern
+
+
+class Checker(object):
+  # filename -> {lineno -> [statements]}
+  _PARSED_FILE_CACHE = defaultdict(lambda: defaultdict(list))
+
+  def __init__(self, filename, lineno, func, args, kwargs, *ignores):
+    self.failed_checks = []
+
+    # _ignore_set is the set of objects that we should never print as local
+    # variables. We start this set off by including the actual Checker object,
+    # since there's no value to printing that.
+    self._ignore_set = {id(x) for x in ignores+(self,)}
+
+    self._ctx_filename = filename
+    self._ctx_lineno = lineno
+    self._ctx_funcname = _nameOfCallable(func)
+    self._ctx_args = map(repr, args)
+    self._ctx_kwargs = {k: repr(v) for k, v in kwargs.iteritems()}
+
+  def _get_statements_for_frame(self, frame):
+    """This parses the file containing frame, and then extracts all simple
+    statements (i.e. those which do not contain other statements). It then
+    returns the list of all statements (as AST nodes) which occur on the line
+    number indicated by the frame.
+
+    The parse and statement extraction is cached in the _PARSED_FILE_CACHE class
+    variable, so multiple assertions in the same file only pay the parsing cost
+    once.
+    """
+    raw_frame, filename, lineno, _, _, _ = frame
+    if filename not in self._PARSED_FILE_CACHE:
+      to_push = ['body', 'orelse', 'finalbody', 'excepthandler']

[martiniss, 2016/10/13 22:54:12]

Can you document what these are? I'm not sure what body is...

The logic here is a bit hard to unravel

[iannucci, 2016/10/13 23:05:05]

added a bunch of comments

+      lines, _ = inspect.findsource(raw_frame)
+      queue = deque([ast.parse(''.join(lines), filename)])
+      while queue:
+        node = queue.pop()
+        had_statements = False
+        for key in to_push:
+          val = getattr(node, key, MISSING)
+          if val is not MISSING:
+            had_statements = True
+            queue.extend(val[::-1])
+        if had_statements:
+          continue
+        max_line = max(map(lambda n: getattr(n, 'lineno', 0), ast.walk(node)))
+        self._PARSED_FILE_CACHE[filename][max_line].append(node)
+    return self._PARSED_FILE_CACHE[filename][lineno]
+
+  def _process_frame(self, frame, with_vars):
+    """This processes a stack frame into an expect_tests.CheckFrame, which
+    includes file name, line number, function name (of the function containing
+    the frame), the parsed statement at that line, and the relevant local
+    variables/subexpressions (if with_vars is True).
+
+    In addition to transforming the expression with _checkTransformer, this
+    will:
+      * omit subexpressions which resolve to callable()'s
+      * omit the overall step ordered dictionary
+      * transform all subexpression values using render_user_value().
+    """
+    nodes = self._get_statements_for_frame(frame)
+    raw_frame, filename, lineno, func_name, _, _ = frame
+
+    varmap = None
+    if with_vars:
+      varmap = {}
+
+      xfrmr = _checkTransformer(raw_frame.f_locals, raw_frame.f_globals)
+      xfrmd = xfrmr.visit(ast.Module(copy.deepcopy(nodes)))
+
+      for n in itertools.chain(ast.walk(xfrmd), xfrmr.extras):
+        if isinstance(n, _resolved):
+          val = n.value
+          if isinstance(val, ast.AST):
+            continue
+          if n.representation in ('True', 'False', 'None'):
+            continue
+          if callable(val) or id(val) in self._ignore_set:
+            continue
+          if n.representation not in varmap:
+            varmap[n.representation] = render_user_value(val)
+
+    return expect_tests.CheckFrame(
+      filename,
+      lineno,
+      func_name,
+      '; '.join(astunparse.unparse(n).strip() for n in nodes),
+      varmap
+    )
+
+  def _call_impl(self, hint, exp):
+    """This implements the bulk of what happens when you run `check(exp)`. It
+    will crawl back up the stack and extract information about all of the frames
+    which are relevent to the check, including file:lineno and the code
+    statement which occurs at that location for all the frames.
+
+    On the last frame (the one that actually contains the check call), it will
+    also try to obtain relevant local values in the check so they can be printed
+    with the check to aid in debugging and diagnosis. It uses the parsed
+    statement found at that line to find all referenced local variables in that
+    frame.
+    """
+
+    if exp:
+      # TODO(iannucci): collect this in verbose mode.
+      # this check passed
+      return
+
+    try:
+      frames = inspect.stack()[2:]
+
+      # grab all frames which have self as a local variable (e.g. frames
+      # associated with this checker), excluding self.__call__.
+      try:
+        i = 0
+        for i, f in enumerate(frames):
+          if self not in f[0].f_locals.itervalues():
+            break
+        keep_frames = [self._process_frame(f, j == 0)
+                       for j, f in enumerate(frames[:i-1])]
+      finally:
+        del f
+
+      # order it so that innermost frame is at the bottom
+      keep_frames = keep_frames[::-1]
+
+      self.failed_checks.append(expect_tests.Check(
+        hint,
+        self._ctx_filename,
+        self._ctx_lineno,
+        self._ctx_funcname,
+        self._ctx_args,
+        self._ctx_kwargs,
+        keep_frames,
+        False
+      ))
+    finally:
+      # avoid reference cycle as suggested by inspect docs.
+      del frames
+
+  def __call__(self, arg1, arg2=None):
+    if arg2 is not None:
+      hint = arg1
+      exp = arg2
+    else:
+      hint = None
+      exp = arg1
+    self._call_impl(hint, exp)
+
+
+MISSING = object()
+
+
+def VerifySubset(a, b):
+  """Verify subset verifies that `a` is a subset of `b` where a and b are both
+  JSON-ish types. They are also permitted to be OrderedDicts instead of
+  dictionaries.
+
+  This verifies that a introduces no extra dictionary keys, list elements, etc.
+  and also ensures that the order of entries in an ordered type (such as a list
+  or an OrderedDict) remain the same from a to b. This also verifies that types
+  are consistent between a and b.
+
+  As a special case, empty and single-element dictionaries are considered
+  subsets of an OrderedDict, even though their types don't precisely match.
+
+  If a is a vaild subset of b, this returns None. Otherwise this returns

[martiniss, 2016/10/13 22:54:12]

typo

[iannucci, 2016/10/13 23:05:05]

Done.

+  a descriptive message of what went wrong.
+
+  Example:
+    print 'object'+VerifySubset({'a': 'thing'}, {'b': 'other', 'a': 'prime'})
+
+  OUTPUT:
+    object['a']: 'thing' != 'prime'
+  """
+  if a is b:
+    return
+
+  if isinstance(b, OrderedDict) and isinstance(a, dict):
+    # 0 and 1-element dicts can stand in for OrderedDicts.
+    if len(a) == 0:
+      return
+    elif len(a) == 1:
+      a = OrderedDict([a.popitem()])
+
+  if type(a) != type(b):
+    return ': type mismatch: %r v %r' % (type(a).__name__, type(b).__name__)
+
+  if isinstance(a, OrderedDict):
+    last_idx = 0
+    b_reverse_index = {k: (i, v) for i, (k, v) in enumerate(b.iteritems())}
+    for k, v in a.iteritems():
+      j, b_val = b_reverse_index.get(k, (MISSING, MISSING))
+      if j is MISSING:
+        return ': added key %r' % k
+
+      if j < last_idx:
+        return ': key %r is out of order' % k
+      # j == last_idx is not possible, these are OrderedDicts
+      last_idx = j
+
+      msg = VerifySubset(v, b_val)
+      if msg:
+        return '[%r]%s' % (k, msg)
+
+  elif isinstance(a, dict):
+    for k, v in a.iteritems():
+      b_val = b.get(k, MISSING)
+      if b_val is MISSING:
+        return ': added key %r' % k
+
+      msg = VerifySubset(v, b_val)
+      if msg:
+        return '[%r]%s' % (k, msg)
+
+  elif isinstance(a, list):
+    if len(a) > len(b):
+      return ': too long: %d v %d' % (len(a), len(b))
+
+    bi = ai = 0
+    while bi < len(b) - 1 and ai < len(a) - 1:
+      msg = VerifySubset(a[ai], b[bi])
+      if msg is None:
+        ai += 1
+      bi += 1
+    if ai != len(a) - 1:
+      return ': added %d elements' % (len(a)-1-ai)
+
+  elif isinstance(a, (basestring, int, bool, type(None))):
+    if a != b:
+      return ': %r != %r' % (a, b)
+
+  else:
+    return ': unknown type: %r' % (type(a).__name__)
+
+
+def _nameOfCallable(c):
+  if hasattr(c, '__call__'):
+    return c.__class__.__name__+'.__call__'
+  if inspect.ismethod(c):
+    return c.im_class.__name__+'.'+c.__name__
+  if inspect.isfunction(c):
+    return c.__name__
+  return repr(c)