Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/gn/desc_builder.cc

Issue 2387763002: Support for source_target_relative expansion in GN (Closed)
Patch Set: Reimplemented as source_target_relative Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/bundle_file_rule.cc ('k') | tools/gn/docs/reference.md » ('j') | tools/gn/function_process_file_template.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/desc_builder.cc
diff --git a/tools/gn/desc_builder.cc b/tools/gn/desc_builder.cc
index 3e2aaa0807eee9998c841ebee31573edb17e537a..a1a5710fc12eac1817010698cfc9861af87a3aa2 100644
--- a/tools/gn/desc_builder.cc
+++ b/tools/gn/desc_builder.cc
@@ -616,8 +616,9 @@ class TargetDescBuilder : public BaseDescBuilder {
res->SetWithoutPathExpansion("output_patterns", std::move(patterns));
}
std::vector<SourceFile> output_files;
- SubstitutionWriter::ApplyListToSources(target_->settings(), outputs,
- target_->sources(), &output_files);
+ SubstitutionWriter::ApplyListToSources(target_, target_->settings(),
+ outputs, target_->sources(),
+ &output_files);
res->SetWithoutPathExpansion(variables::kOutputs,
RenderValue(output_files));
} else {
« no previous file with comments | « tools/gn/bundle_file_rule.cc ('k') | tools/gn/docs/reference.md » ('j') | tools/gn/function_process_file_template.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698