Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 2387753002: Release read buffer of QuicCryptoStream when incoming message become less frequent. Protected by --… (Closed)

Created:
4 years, 2 months ago by danzh1
Modified:
4 years, 2 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Release read buffer of QuicCryptoStream when incoming message become less frequent. Protected by --quic_release_crypto_stream_buffer. Release the buffer when handshake has been confirmed and complete handshake message has been read out and no further bytes are in buffer. Merge internal change: 134493398 and 134809175. BUG=635041 Committed: https://crrev.com/43eb0ff7957852816782585938122a25b1684601 Cr-Commit-Position: refs/heads/master@{#422426}

Patch Set 1 #

Patch Set 2 : turn flag off #

Patch Set 3 : add new files #

Patch Set 4 : enable quic crypto stream release buffer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+274 lines, -110 lines) Patch
M net/net.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/core/quic_crypto_client_stream_test.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M net/quic/core/quic_crypto_stream.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M net/quic/core/quic_flags_list.h View 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/core/quic_stream_sequencer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/core/quic_stream_sequencer.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M net/quic/core/quic_stream_sequencer_buffer_test.cc View 2 chunks +1 line, -110 lines 0 comments Download
A net/quic/test_tools/quic_stream_sequencer_buffer_peer.h View 1 2 1 chunk +63 lines, -0 lines 0 comments Download
A net/quic/test_tools/quic_stream_sequencer_buffer_peer.cc View 1 2 1 chunk +142 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_stream_sequencer_peer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_stream_sequencer_peer.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M net/quic/test_tools/reliable_quic_stream_peer.h View 2 chunks +3 lines, -0 lines 0 comments Download
M net/quic/test_tools/reliable_quic_stream_peer.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 2 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (18 generated)
danzh1
4 years, 2 months ago (2016-09-30 19:09:03 UTC) #6
Ryan Hamilton
lgtm
4 years, 2 months ago (2016-09-30 22:14:04 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2387753002/40001
4 years, 2 months ago (2016-10-03 14:18:03 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-03 15:30:56 UTC) #21
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 15:33:23 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/43eb0ff7957852816782585938122a25b1684601
Cr-Commit-Position: refs/heads/master@{#422426}

Powered by Google App Engine
This is Rietveld 408576698