Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 238773003: Removed EnterIsolateIfNeeded and a soon-to-be-useless assertion. (Closed)

Created:
6 years, 8 months ago by Sven Panne
Modified:
6 years, 8 months ago
Reviewers:
dcarney
CC:
v8-dev
Visibility:
Public.

Description

Removed EnterIsolateIfNeeded and a soon-to-be-useless assertion. BUG=359977 LOG=y R=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20759

Patch Set 1 #

Patch Set 2 : Rebased. #

Patch Set 3 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -27 lines) Patch
M src/api.cc View 1 4 chunks +5 lines, -23 lines 0 comments Download
M src/isolate.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sven Panne
6 years, 8 months ago (2014-04-15 09:48:02 UTC) #1
dcarney
lgtm
6 years, 8 months ago (2014-04-15 10:33:46 UTC) #2
Sven Panne
6 years, 8 months ago (2014-04-15 10:45:41 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r20759 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698