Resume a backgrounded renderer that was purged and suspended

chrome/browser/memory/tab_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/memory/tab_manager.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <set>
@@ skipping 66 matching lines @@
 // For each period of this length record a statistic to indicate whether or not
 // the user experienced a low memory event. If this interval is changed,
 // Tabs.Discard.DiscardInLastMinute must be replaced with a new statistic.
 const int kRecentTabDiscardIntervalSeconds = 60;
 #endif
 
 // If there has been no priority adjustment in this interval, assume the
 // machine was suspended and correct the timing statistics.
 const int kSuspendThresholdSeconds = kAdjustmentIntervalSeconds * 4;
 
+// If a backgrounded renderer is kept backgrounded during this time after
+// suspended, resume the renderer to avoid breaking web.
+const int kResumeSuspendedRendererMinutes = 20;

[haraken, 2016/10/06 07:29:05]

I'd say 20 seconds would be too short.

[tasak, 2016/10/06 08:02:06]

2min.
Done.

+
+// After resuming and running a backgrounded rendererr for this period,

[haraken, 2016/10/06 07:29:05]

renderer

[tasak, 2016/10/06 08:02:06]

Done.

+// the renderer is purged and suspended again.
+const int kSuspendResumedRendererMinutes = 2;

[haraken, 2016/10/06 07:29:05]

Would it be hard to run the renderer until it has drained all pending tasks?

[tasak, 2016/10/06 08:02:06]

I think, it is difficult to ask task runners in tab_manager.

+
 // The time during which a tab is protected from discarding after it stops being
 // audible.
 const int kAudioProtectionTimeSeconds = 60;
 
 int FindTabStripModelById(int64_t target_web_contents_id,
                           TabStripModel** model) {
   DCHECK(model);
   for (auto* browser : *BrowserList::GetInstance()) {
     TabStripModel* local_model = browser->tab_strip_model();
     for (int idx = 0; idx < local_model->count(); idx++) {
@@ skipping 579 matching lines @@
   if (!command_line.HasSwitch(switches::kPurgeAndSuspendTime))
     return;
   int purge_and_suspend_time = 0;
   if (!base::StringToInt(
           command_line.GetSwitchValueASCII(switches::kPurgeAndSuspendTime),
           &purge_and_suspend_time)) {
     return;
   }
   if (purge_and_suspend_time <= 0)
     return;
+  base::TimeTicks current_time = NowTicks();
   auto purge_and_suspend_time_threshold =
-      NowTicks() - base::TimeDelta::FromSeconds(purge_and_suspend_time);
+      current_time - base::TimeDelta::FromSeconds(purge_and_suspend_time);
   auto tab_stats = GetUnsortedTabStats();
   for (auto& tab : tab_stats) {
     if (!tab.render_process_host->IsProcessBackgrounded())
       continue;
     // TODO(hajimehoshi): Now calling PurgeAndSuspend is implemented without
     // timers for simplicity, so PurgeAndSuspend is called even after the
     // renderer is purged and suspended once. This should be replaced with
     // timers if we want necessary and sufficient signals.
     if (tab.last_active > purge_and_suspend_time_threshold)
       continue;
-    tab.render_process_host->PurgeAndSuspend();
+
+    auto last_purged_and_suspended_time =
+        tab.render_process_host->GetLastPurgedAndSuspendedTime();
+    auto last_resumed_time =
+        tab.render_process_host->GetLastResumedInBackgroundTime();
+
+    if (last_purged_and_suspended_time < tab.last_active ||
+        (last_resumed_time > last_purged_and_suspended_time &&
+         last_purged_and_suspended_time > tab.last_active &&
+         ((current_time - last_resumed_time) >
+          base::TimeDelta::FromMinutes(kSuspendResumedRendererMinutes)))) {
+      tab.render_process_host->PurgeAndSuspend();
+      if (!task_runner_.get())
+        task_runner_ = base::ThreadTaskRunnerHandle::Get();
+    } else {
+      auto delta = current_time - last_purged_and_suspended_time;
+      if (last_resumed_time < last_purged_and_suspended_time &&
+          delta > base::TimeDelta::FromMinutes(kResumeSuspendedRendererMinutes))
+        tab.render_process_host->Resume();
+    }
   }
 }
 
 WebContents* TabManager::DiscardWebContentsAt(int index, TabStripModel* model) {
   // Can't discard active index.
   if (model->active_index() == index)
     return nullptr;
 
   WebContents* old_contents = model->GetWebContentsAt(index);
 
@@ skipping 231 matching lines @@
   // platform.
   std::string allow_multiple_discards = variations::GetVariationParamValue(
       features::kAutomaticTabDiscarding.name, "AllowMultipleDiscards");
   return (allow_multiple_discards != "true");
 #else
   return false;
 #endif
 }
 
 }  // namespace memory