Issue 2387603002: Revert "[inspector] added inspector test runner [part 1-2]"

Issue 2387603002: Revert "[inspector] added inspector test runner [part 1-2]" (Closed)

Created:
4 years, 2 months ago by Michael Achenbach

Modified:
4 years, 2 months ago

Reviewers:
kozy, Michael Hablich

CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Revert "[inspector] added inspector test runner [part 1-2]" Revert "[inspector] added inspector test runner [part 1]" This reverts commit dc1c71c0dc8a5c4ade4aa291f2ddcd02e90c64b2. Revert "[inspector] added inspector test runner [part 2]" This reverts commit cceaa1225c6a96a28d2c7410d1db520423fb8c31. Blocks the roll: https://codereview.chromium.org/2379053003/ In particular android debug: https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/137605 BUG=chromium:635948 TBR=kozyatinskiy@chromium.org, NOTRY=true Committed: https://crrev.com/0e704cdac6c684c965ed57add4d5bbb9cb7acfdb Cr-Commit-Position: refs/heads/master@{#39909}

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -541 lines)			Patch
M	test/BUILD.gn	View	2 chunks	+0 lines, -5 lines	0 comments	Download
D	test/inspector/BUILD.gn	View	1 chunk	+0 lines, -38 lines	0 comments	Download
D	test/inspector/DEPS	View	1 chunk	+0 lines, -7 lines	0 comments	Download
D	test/inspector/OWNERS	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	test/inspector/inspector.gyp	View	1 chunk	+0 lines, -40 lines	0 comments	Download
D	test/inspector/inspector-impl.h	View	1 chunk	+0 lines, -76 lines	0 comments	Download
D	test/inspector/inspector-impl.cc	View	1 chunk	+0 lines, -152 lines	0 comments	Download
D	test/inspector/task-runner.h	View	1 chunk	+0 lines, -79 lines	0 comments	Download
D	test/inspector/task-runner.cc	View	1 chunk	+0 lines, -137 lines	0 comments	Download
M	tools/presubmit.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/verify_source_deps.py	View	4 chunks	+0 lines, -4 lines	0 comments	Download

Total messages: 10 (5 generated)

Michael Achenbach

Please include the chromium trybots android_clang_dbg_recipe and android_arm64_dbg_recipe on reland of the v8 CLs.

4 years, 2 months ago (2016-09-30 09:53:11 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2387603002/1

4 years, 2 months ago (2016-09-30 09:53:26 UTC) #5

commit-bot: I haz the power

Description was changed from ========== Revert "[inspector] added inspector test runner [part 1-2]" Revert "[inspector] ...

4 years, 2 months ago (2016-09-30 09:56:07 UTC) #8

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/0e704cdac6c684c965ed57add4d5bbb9cb7acfdb Cr-Commit-Position: refs/heads/master@{#39909}

4 years, 2 months ago (2016-09-30 09:56:08 UTC) #9

Michael Hablich

4 years, 2 months ago (2016-09-30 09:56:10 UTC) #10

Message was sent while issue was closed.

On 2016/09/30 09:55:48, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1)

lgtm