Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1029)

Unified Diff: tools/metrics/actions/extract_actions.py

Issue 23876026: Add UMA stats for how often we get a 200 for a byte-range request for NPAPI plugins. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/metrics/actions/chromeactions.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/actions/extract_actions.py
===================================================================
--- tools/metrics/actions/extract_actions.py (revision 223113)
+++ tools/metrics/actions/extract_actions.py (working copy)
@@ -169,27 +169,29 @@
Arguments
actions: set of actions to add to.
"""
- actions.add('PDF.PrintPage')
actions.add('PDF.FitToHeightButton')
actions.add('PDF.FitToWidthButton')
actions.add('PDF.LoadFailure')
actions.add('PDF.LoadSuccess')
actions.add('PDF.PreviewDocumentLoadFailure')
+ actions.add('PDF.PrintButton')
+ actions.add('PDF.PrintPage')
+ actions.add('PDF.SaveButton')
actions.add('PDF.ZoomFromBrowser')
+ actions.add('PDF.ZoomInButton')
actions.add('PDF.ZoomOutButton')
- actions.add('PDF.ZoomInButton')
- actions.add('PDF_Unsupported_Rights_Management')
- actions.add('PDF_Unsupported_XFA')
actions.add('PDF_Unsupported_3D')
+ actions.add('PDF_Unsupported_Attachment')
+ actions.add('PDF_Unsupported_Bookmarks')
+ actions.add('PDF_Unsupported_Digital_Signature')
actions.add('PDF_Unsupported_Movie')
- actions.add('PDF_Unsupported_Sound')
+ actions.add('PDF_Unsupported_Portfolios_Packages')
+ actions.add('PDF_Unsupported_Rights_Management')
actions.add('PDF_Unsupported_Screen')
- actions.add('PDF_Unsupported_Portfolios_Packages')
- actions.add('PDF_Unsupported_Attachment')
- actions.add('PDF_Unsupported_Digital_Signature')
+ actions.add('PDF_Unsupported_Shared_Form')
actions.add('PDF_Unsupported_Shared_Review')
- actions.add('PDF_Unsupported_Shared_Form')
- actions.add('PDF_Unsupported_Bookmarks')
+ actions.add('PDF_Unsupported_Sound')
+ actions.add('PDF_Unsupported_XFA')
def AddAndroidActions(actions):
"""Add actions that are used by Chrome on Android.
@@ -477,12 +479,17 @@
# We look for the ViewHostMsg_UserMetricsRecordAction constructor.
# This should be on one line.
action_re = re.compile(
- r'[^a-zA-Z]RenderThread::RecordUserMetrics\("([^"]*)')
- line_number = 0
+ r'[^a-zA-Z]RenderThread::Get\(\)->RecordUserMetrics\("([^"]*)')
+ action_re2 = re.compile(
+ r'[^a-zA-Z]RenderThreadImpl::current\(\)->RecordUserMetrics\("([^"]*)')
for line in open(path):
match = action_re.search(line)
- if match: # Plain call to RecordAction
+ if match: # Call to RecordUserMetrics through Content API
actions.add(match.group(1))
+ continue
+ match = action_re2.search(line)
+ if match: # Call to RecordUserMetrics inside Content
+ actions.add(match.group(1))
def AddLiteralActions(actions):
"""Add literal actions specified via calls to UserMetrics functions.
« no previous file with comments | « tools/metrics/actions/chromeactions.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698