Add UMA stats for how often we get a 200 for a byte-range request for NPAPI plugins.

tools/metrics/actions/extract_actions.py

 #!/usr/bin/env python
 #
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Extract UserMetrics "actions" strings from the Chrome source.
 
 This program generates the list of known actions we expect to see in the
 user behavior logs.  It walks the Chrome source, looking for calls to
@@ skipping 156 matching lines @@
   """Add actions that are in code which is not checked out by default
 
   Arguments
     actions: set of actions to add to.
   """
   actions.add('PDF.PrintPage')
   actions.add('PDF.FitToHeightButton')
   actions.add('PDF.FitToWidthButton')
   actions.add('PDF.LoadFailure')
   actions.add('PDF.LoadSuccess')
+  actions.add('PDF.SaveButton')
+  actions.add('PDF.PrintButton')

[Ilya Sherman, 2013/09/14 03:07:30]

nit: Please alphabetize (I know the list is already not ordered, but we can at
least keep it from getting worse).

[jam, 2013/09/15 21:58:14]

Done.

   actions.add('PDF.PreviewDocumentLoadFailure')
   actions.add('PDF.ZoomFromBrowser')
   actions.add('PDF.ZoomOutButton')
   actions.add('PDF.ZoomInButton')
   actions.add('PDF_Unsupported_Rights_Management')
   actions.add('PDF_Unsupported_XFA')
   actions.add('PDF_Unsupported_3D')
   actions.add('PDF_Unsupported_Movie')
   actions.add('PDF_Unsupported_Sound')
   actions.add('PDF_Unsupported_Screen')
@@ skipping 283 matching lines @@
 def GrepForRendererActions(path, actions):
   """Grep a source file for calls to RenderThread::RecordUserMetrics.
 
   Arguments:
     path: path to the file
     actions: set of actions to add to
   """
   # We look for the ViewHostMsg_UserMetricsRecordAction constructor.
   # This should be on one line.
   action_re = re.compile(
-      r'[^a-zA-Z]RenderThread::RecordUserMetrics\("([^"]*)')
+      r'[^a-zA-Z]RenderThread::Get\(\)->RecordUserMetrics\("([^"]*)')
+  action_re2 = re.compile(
+      r'[^a-zA-Z]RenderThreadImpl::current\(\)->RecordUserMetrics\("([^"]*)')

[Ilya Sherman, 2013/09/14 03:07:30]

Hmm, why doesn't the RenderThread class use the UserMetricsAction struct that
other locations for recording user actions do?  That struct exists pretty much
just to simplify grepping.

[jam, 2013/09/15 21:58:14]

UserMetricsAction is used in the browser process, but not in the renderer

[Ilya Sherman, 2013/09/16 19:50:03]

Yes, I see that that's currently the case.  My question is: Why is that the
case?  It seems like it would simplify things to just use UserMetricsAction
everywhere we can.  (Note: While I think fixing this would be a nice
improvement, this comment is not blocking the CL.)

   line_number = 0

[Ilya Sherman, 2013/09/14 03:07:30]

As long as you're editing nearby code, let's get rid of this unused variable.

[jam, 2013/09/15 21:58:14]

Done.

   for line in open(path):
     match = action_re.search(line)
-    if match:  # Plain call to RecordAction
+    if match:  # Call to RecordUserMetrics through Content API
+      actions.add(match.group(1))
+      continue
+    match = action_re2.search(line)
+    if match:  # Call to RecordUserMetrics inside Content
       actions.add(match.group(1))
 
 def AddLiteralActions(actions):
   """Add literal actions specified via calls to UserMetrics functions.
 
   Arguments:
     actions: set of actions to add to.
   """
   EXTENSIONS = ('.cc', '.mm', '.c', '.m')
 
@@ skipping 126 matching lines @@
     else:
       print action
 
   if hash_output:
     print "Done. Do not forget to add chromeactions.txt to your changelist"
   return 0
 
 
 if '__main__' == __name__:
   sys.exit(main(sys.argv))