Source/bindings/v8/V8WindowShell.cpp - Issue 23876015: Pass isolate to v8::Local<>::New() factory function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/V8WindowShell.cpp

Issue 23876015: Pass isolate to v8::Local<>::New() factory function (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Use isolateForFrame() Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/V8WindowShell.cpp

diff --git a/Source/bindings/v8/V8WindowShell.cpp b/Source/bindings/v8/V8WindowShell.cpp

index c7dd679148e43c08c502f88bf01f7674f77c1d5c..05221c1dba05ccaad2ec5bb33ba85b86ea3f1549 100644

--- a/Source/bindings/v8/V8WindowShell.cpp

+++ b/Source/bindings/v8/V8WindowShell.cpp

@@ -244,7 +244,7 @@ bool V8WindowShell::initializeIfNeeded()

SecurityOrigin* origin = m_world->isolatedWorldSecurityOrigin();

if (origin && InspectorInstrumentation::hasFrontends()) {

- ScriptState* scriptState = ScriptState::forContext(v8::Local<v8::Context>::New(context));

+ ScriptState* scriptState = ScriptState::forContext(v8::Local<v8::Context>::New(m_isolate, context));

InspectorInstrumentation::didCreateIsolatedContext(m_frame, scriptState, origin);

}