Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Unified Diff: Source/bindings/v8/ScriptController.cpp

Issue 23876015: Pass isolate to v8::Local<>::New() factory function (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Use isolateForFrame() Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/v8/SerializedScriptValue.cpp » ('j') | Source/web/WebFrameImpl.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/ScriptController.cpp
diff --git a/Source/bindings/v8/ScriptController.cpp b/Source/bindings/v8/ScriptController.cpp
index db933b84f093573133af1412ac2c01af40e0b1cc..031928d25d45369d9925ab5f6ba0fedbf1f9e193 100644
--- a/Source/bindings/v8/ScriptController.cpp
+++ b/Source/bindings/v8/ScriptController.cpp
@@ -325,7 +325,7 @@ v8::Local<v8::Context> ScriptController::currentWorldContext()
return v8::Local<v8::Context>();
if (m_frame == frame)
- return v8::Local<v8::Context>::New(context);
+ return v8::Local<v8::Context>::New(m_isolate, context);
return contextForWorld(this, isolatedWorld);
}
@@ -707,7 +707,7 @@ void ScriptController::executeScriptInIsolatedWorld(int worldID, const Vector<Sc
for (size_t i = 0; i < sources.size(); ++i) {
v8::Local<v8::Value> evaluationResult = compileAndRunScript(sources[i]);
if (evaluationResult.IsEmpty())
- evaluationResult = v8::Local<v8::Value>::New(v8::Undefined());
+ evaluationResult = v8::Local<v8::Value>::New(m_isolate, v8::Undefined(m_isolate));
resultArray->Set(i, evaluationResult);
}
« no previous file with comments | « no previous file | Source/bindings/v8/SerializedScriptValue.cpp » ('j') | Source/web/WebFrameImpl.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698