Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Side by Side Diff: Source/bindings/v8/V8Binding.cpp

Issue 23876015: Pass isolate to v8::Local<>::New() factory function (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Use isolateForFrame() Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 379 matching lines...) Expand 10 before | Expand all | Expand 10 after
390 390
391 v8::Handle<v8::FunctionTemplate> createRawTemplate(v8::Isolate* isolate) 391 v8::Handle<v8::FunctionTemplate> createRawTemplate(v8::Isolate* isolate)
392 { 392 {
393 v8::HandleScope scope(isolate); 393 v8::HandleScope scope(isolate);
394 v8::Local<v8::FunctionTemplate> result = v8::FunctionTemplate::New(V8ObjectC onstructor::isValidConstructorMode); 394 v8::Local<v8::FunctionTemplate> result = v8::FunctionTemplate::New(V8ObjectC onstructor::isValidConstructorMode);
395 return scope.Close(result); 395 return scope.Close(result);
396 } 396 }
397 397
398 PassRefPtr<DOMStringList> toDOMStringList(v8::Handle<v8::Value> value, v8::Isola te* isolate) 398 PassRefPtr<DOMStringList> toDOMStringList(v8::Handle<v8::Value> value, v8::Isola te* isolate)
399 { 399 {
400 v8::Local<v8::Value> v8Value(v8::Local<v8::Value>::New(value)); 400 v8::Local<v8::Value> v8Value(v8::Local<v8::Value>::New(isolate, value));
401 401
402 if (V8DOMStringList::HasInstance(v8Value, isolate, worldType(isolate))) { 402 if (V8DOMStringList::HasInstance(v8Value, isolate, worldType(isolate))) {
403 RefPtr<DOMStringList> ret = V8DOMStringList::toNative(v8::Handle<v8::Obj ect>::Cast(v8Value)); 403 RefPtr<DOMStringList> ret = V8DOMStringList::toNative(v8::Handle<v8::Obj ect>::Cast(v8Value));
404 return ret.release(); 404 return ret.release();
405 } 405 }
406 406
407 if (!v8Value->IsArray()) 407 if (!v8Value->IsArray())
408 return 0; 408 return 0;
409 409
410 RefPtr<DOMStringList> ret = DOMStringList::create(); 410 RefPtr<DOMStringList> ret = DOMStringList::create();
(...skipping 190 matching lines...) Expand 10 before | Expand all | Expand 10 after
601 } 601 }
602 return v8::Isolate::GetCurrent(); 602 return v8::Isolate::GetCurrent();
603 } 603 }
604 604
605 v8::Isolate* isolateForFrame(Frame* frame) 605 v8::Isolate* isolateForFrame(Frame* frame)
606 { 606 {
607 return frame->script()->isolate(); 607 return frame->script()->isolate();
608 } 608 }
609 609
610 } // namespace WebCore 610 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698