Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Side by Side Diff: Source/bindings/v8/V8AbstractEventListener.cpp

Issue 23876015: Pass isolate to v8::Local<>::New() factory function (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Use isolateForFrame() Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 165 matching lines...) Expand 10 before | Expand all | Expand 10 after
176 { 176 {
177 v8::Isolate* isolate = toV8Context(context, world())->GetIsolate(); 177 v8::Isolate* isolate = toV8Context(context, world())->GetIsolate();
178 v8::Local<v8::Object> listener = m_listener.newLocal(isolate); 178 v8::Local<v8::Object> listener = m_listener.newLocal(isolate);
179 if (!m_listener.isEmpty() && !listener->IsFunction()) 179 if (!m_listener.isEmpty() && !listener->IsFunction())
180 return listener; 180 return listener;
181 181
182 EventTarget* target = event->currentTarget(); 182 EventTarget* target = event->currentTarget();
183 v8::Handle<v8::Value> value = toV8(target, v8::Handle<v8::Object>(), isolate ); 183 v8::Handle<v8::Value> value = toV8(target, v8::Handle<v8::Object>(), isolate );
184 if (value.IsEmpty()) 184 if (value.IsEmpty())
185 return v8::Local<v8::Object>(); 185 return v8::Local<v8::Object>();
186 return v8::Local<v8::Object>::New(v8::Handle<v8::Object>::Cast(value)); 186 return v8::Local<v8::Object>::New(isolate, v8::Handle<v8::Object>::Cast(valu e));
187 } 187 }
188 188
189 void V8AbstractEventListener::makeWeakCallback(v8::Isolate*, v8::Persistent<v8:: Object>*, V8AbstractEventListener* listener) 189 void V8AbstractEventListener::makeWeakCallback(v8::Isolate*, v8::Persistent<v8:: Object>*, V8AbstractEventListener* listener)
190 { 190 {
191 listener->m_listener.clear(); 191 listener->m_listener.clear();
192 } 192 }
193 193
194 } // namespace WebCore 194 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698