Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: Source/bindings/v8/V8AbstractEventListener.cpp

Issue 23876015: Pass isolate to v8::Local<>::New() factory function (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 163 matching lines...) Expand 10 before | Expand all | Expand 10 after
174 { 174 {
175 v8::Isolate* isolate = toV8Context(context, world())->GetIsolate(); 175 v8::Isolate* isolate = toV8Context(context, world())->GetIsolate();
176 v8::Local<v8::Object> listener = m_listener.newLocal(isolate); 176 v8::Local<v8::Object> listener = m_listener.newLocal(isolate);
177 if (!m_listener.isEmpty() && !listener->IsFunction()) 177 if (!m_listener.isEmpty() && !listener->IsFunction())
178 return listener; 178 return listener;
179 179
180 EventTarget* target = event->currentTarget(); 180 EventTarget* target = event->currentTarget();
181 v8::Handle<v8::Value> value = toV8(target, v8::Handle<v8::Object>(), isolate ); 181 v8::Handle<v8::Value> value = toV8(target, v8::Handle<v8::Object>(), isolate );
182 if (value.IsEmpty()) 182 if (value.IsEmpty())
183 return v8::Local<v8::Object>(); 183 return v8::Local<v8::Object>();
184 return v8::Local<v8::Object>::New(v8::Handle<v8::Object>::Cast(value)); 184 return v8::Local<v8::Object>::New(isolate, v8::Handle<v8::Object>::Cast(valu e));
185 } 185 }
186 186
187 void V8AbstractEventListener::makeWeakCallback(v8::Isolate*, v8::Persistent<v8:: Object>*, V8AbstractEventListener* listener) 187 void V8AbstractEventListener::makeWeakCallback(v8::Isolate*, v8::Persistent<v8:: Object>*, V8AbstractEventListener* listener)
188 { 188 {
189 listener->m_listener.clear(); 189 listener->m_listener.clear();
190 } 190 }
191 191
192 } // namespace WebCore 192 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698