Issue 23876008: Add Clock Sample.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23876008: Add Clock Sample. (Closed)

Created:
7 years, 3 months ago by jvanverth1

Modified:
7 years, 3 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com, tfarina

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Add Clock Sample. There are two possible rendering methods: paths (default) or primitives. At the moment the rrect primitive only supports axis-aligned rrects for GPU acceleration, so that will not be a win on GPU. R=reed@google.com Committed: https://code.google.com/p/skia/source/detail?r=11330

Patch Set 1 #

Total comments: 3

Patch Set 2 : Pre-commit cleanup #

Patch Set 3 : Clean up for commit #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+230 lines, -0 lines)			Patch
	M	gyp/SampleApp.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
	A	samplecode/SampleClock.cpp	View	1 2	1 chunk	+229 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

tfarina

https://codereview.chromium.org/23876008/diff/1/samplecode/SampleClock.cpp File samplecode/SampleClock.cpp (right): https://codereview.chromium.org/23876008/diff/1/samplecode/SampleClock.cpp#newcode1 samplecode/SampleClock.cpp:1: rm this blank line. https://codereview.chromium.org/23876008/diff/1/samplecode/SampleClock.cpp#newcode3 samplecode/SampleClock.cpp:3: * Copyright 2011 ...

7 years, 3 months ago (2013-09-10 21:59:02 UTC) #3

jvanverth1

7 years, 3 months ago (2013-09-17 19:52:12 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r11330 (presubmit successful).

Expand Messages | Collapse Messages