Refactoring: get rid of the SkBenchmark void* parameter.

bench/BicubicBench.cpp

Index: bench/BicubicBench.cpp
diff --git a/bench/BicubicBench.cpp b/bench/BicubicBench.cpp
index ece7cbe503f484a58f01bf48ce9823bea1725869..4108cda9cdca034d922bf6a1489d937154c72310 100644
--- a/bench/BicubicBench.cpp
+++ b/bench/BicubicBench.cpp
@@ -19,8 +19,9 @@ class BicubicBench : public SkBenchmark {
     SkString       fName;
 
 public:
-    BicubicBench(void* param, float x, float y)
-        :  INHERITED(param), fScale(SkSize::Make(SkFloatToScalar(x), SkFloatToScalar(y))) {
+    BicubicBench(float x, float y)
+        : fScale(SkSize::Make(SkFloatToScalar(x)
+        , SkFloatToScalar(y))) {

[scroggo, 2013/09/10 21:31:15]

This is formatted as if SkFloatToScalar(y) is a parameter to the constructor. It
should be

: fScale(SkSize::Make(SkFloatToScalar(x), SkFloatToScalar(y))) {

or

: fScale(SkSize::Make(SkFloatToScalar(x),
                      SkFloatToScalar(y))) {

[mtklein, 2013/09/11 13:33:01]

Ooh, thanks.  Overzealous reformatting!  Fixed.

         fName.printf("bicubic_%gx%g",
             SkScalarToFloat(fScale.fWidth), SkScalarToFloat(fScale.fHeight));
     }
@@ -52,12 +53,7 @@ private:
     typedef SkBenchmark INHERITED;
 };
 
-static SkBenchmark* Fact00(void* p) { return new BicubicBench(p, 10.0f, 10.0f); }
-static SkBenchmark* Fact01(void* p) { return new BicubicBench(p, 2.5f, 10.0f); }
-static SkBenchmark* Fact02(void* p) { return new BicubicBench(p, 10.0f, 2.5f); }
-static SkBenchmark* Fact03(void* p) { return new BicubicBench(p, 2.5f, 2.5f); }
-
-static BenchRegistry gReg00(Fact00);
-static BenchRegistry gReg01(Fact01);
-static BenchRegistry gReg02(Fact02);
-static BenchRegistry gReg03(Fact03);
+DEF_BENCH( return new BicubicBench(10.0f, 10.0f); )
+DEF_BENCH( return new BicubicBench(2.5f, 10.0f); )
+DEF_BENCH( return new BicubicBench(10.0f, 2.5f); )
+DEF_BENCH( return new BicubicBench(2.5f, 2.5f); )