Implement DisplayInfoProvider::UpdateDisplayUnitInfoForPlatform method for Linux GTK. (Resubmit aft…

Implement DisplayInfoProvider::UpdateDisplayUnitInfoForPlatform method for Linux GTK. (Resubmit after revert)

Also rename display_info_provider_x11 to display_info_provider_gtk for
better understand.

BUG=122863
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222553

[Haojian Wu, 2013-09-06 00:18:05]

The CL:https://codereview.chromium.org/22891026/ got reverted, since it breaks
win_aura building.
 
Resubmit this patch, please review it. Thanks.

[Haojian Wu, 2013-09-06 00:20:35]

https://codereview.chromium.org/23876005/diff/1/chrome/chrome_browser_extensi...
File chrome/chrome_browser_extensions.gypi (right):

https://codereview.chromium.org/23876005/diff/1/chrome/chrome_browser_extensi...
chrome/chrome_browser_extensions.gypi:975: }],
This is only change, exclude display_info_provider_aura.cc file in win_aura
building.

[oshima, 2013-09-06 17:29:23]

https://codereview.chromium.org/23876005/diff/1/chrome/chrome_browser_extensi...
File chrome/chrome_browser_extensions.gypi (right):

https://codereview.chromium.org/23876005/diff/1/chrome/chrome_browser_extensi...
chrome/chrome_browser_extensions.gypi:975: }],
On 2013/09/06 00:20:35, Haojian Wu wrote:
> This is only change, exclude display_info_provider_aura.cc file in win_aura
> building.

win aura does set use_ash=1 You need to exclude this for win for now.

[sadrul, 2013-09-06 17:35:39]

On 2013/09/06 17:29:23, oshima wrote:
>
https://codereview.chromium.org/23876005/diff/1/chrome/chrome_browser_extensi...
> File chrome/chrome_browser_extensions.gypi (right):
> 
>
https://codereview.chromium.org/23876005/diff/1/chrome/chrome_browser_extensi...
> chrome/chrome_browser_extensions.gypi:975: }],
> On 2013/09/06 00:20:35, Haojian Wu wrote:
> > This is only change, exclude display_info_provider_aura.cc file in win_aura
> > building.
> 
> win aura does set use_ash=1 You need to exclude this for win for now.

Drive-by: Is this true? I see that ash_unittests run on both win7-aura and
win8-aura trybots and the win-aura buildbot in the waterfall.

[sadrul, 2013-09-06 17:36:12]

On 2013/09/06 17:35:39, sadrul wrote:
> On 2013/09/06 17:29:23, oshima wrote:
> >
>
https://codereview.chromium.org/23876005/diff/1/chrome/chrome_browser_extensi...
> > File chrome/chrome_browser_extensions.gypi (right):
> > 
> >
>
https://codereview.chromium.org/23876005/diff/1/chrome/chrome_browser_extensi...
> > chrome/chrome_browser_extensions.gypi:975: }],
> > On 2013/09/06 00:20:35, Haojian Wu wrote:
> > > This is only change, exclude display_info_provider_aura.cc file in
win_aura
> > > building.
> > 
> > win aura does set use_ash=1 You need to exclude this for win for now.
> 
> Drive-by: Is this true? I see that ash_unittests run on both win7-aura and
> win8-aura trybots and the win-aura buildbot in the waterfall.

Ah, please ignore. I misread the comment.

[oshima, 2013-09-06 17:43:17]

On 2013/09/06 17:36:12, sadrul wrote:
> On 2013/09/06 17:35:39, sadrul wrote:
> > On 2013/09/06 17:29:23, oshima wrote:
> > >
> >
>
https://codereview.chromium.org/23876005/diff/1/chrome/chrome_browser_extensi...
> > > File chrome/chrome_browser_extensions.gypi (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/23876005/diff/1/chrome/chrome_browser_extensi...
> > > chrome/chrome_browser_extensions.gypi:975: }],
> > > On 2013/09/06 00:20:35, Haojian Wu wrote:
> > > > This is only change, exclude display_info_provider_aura.cc file in
> win_aura
> > > > building.
> > > 
> > > win aura does set use_ash=1 You need to exclude this for win for now.
> > 
> > Drive-by: Is this true? I see that ash_unittests run on both win7-aura and
> > win8-aura trybots and the win-aura buildbot in the waterfall.
> 
> Ah, please ignore. I misread the comment.

:)

[Haojian Wu, 2013-09-07 03:21:26]

https://codereview.chromium.org/23876005/diff/1/chrome/chrome_browser_extensi...
File chrome/chrome_browser_extensions.gypi (right):

https://codereview.chromium.org/23876005/diff/1/chrome/chrome_browser_extensi...
chrome/chrome_browser_extensions.gypi:975: }],
On 2013/09/06 17:29:24, oshima wrote:
> On 2013/09/06 00:20:35, Haojian Wu wrote:
> > This is only change, exclude display_info_provider_aura.cc file in win_aura
> > building.
> 
> win aura does set use_ash=1 You need to exclude this for win for now.
> 

Doesn't the statements here exclude the display_info_provider_aura.cc file?
It passed compiled with use_ash=1 on Windows on my local machine.

[oshima, 2013-09-07 03:25:12]

https://codereview.chromium.org/23876005/diff/1/chrome/chrome_browser_extensi...
File chrome/chrome_browser_extensions.gypi (right):

https://codereview.chromium.org/23876005/diff/1/chrome/chrome_browser_extensi...
chrome/chrome_browser_extensions.gypi:975: }],
On 2013/09/07 03:21:26, Haojian Wu wrote:
> On 2013/09/06 17:29:24, oshima wrote:
> > On 2013/09/06 00:20:35, Haojian Wu wrote:
> > > This is only change, exclude display_info_provider_aura.cc file in
win_aura
> > > building.
> > 
> > win aura does set use_ash=1 You need to exclude this for win for now.
> > 
> 
> Doesn't the statements here exclude the display_info_provider_aura.cc file?
> It passed compiled with use_ash=1 on Windows on my local machine.
> 
Sorry I should have said:

You should always exclude this for win. (no need to check use_ash)

[Haojian Wu, 2013-09-07 03:45:57]

https://codereview.chromium.org/23876005/diff/1/chrome/chrome_browser_extensi...
File chrome/chrome_browser_extensions.gypi (right):

https://codereview.chromium.org/23876005/diff/1/chrome/chrome_browser_extensi...
chrome/chrome_browser_extensions.gypi:975: }],
On 2013/09/07 03:25:12, oshima wrote:
> On 2013/09/07 03:21:26, Haojian Wu wrote:
> > On 2013/09/06 17:29:24, oshima wrote:
> > > On 2013/09/06 00:20:35, Haojian Wu wrote:
> > > > This is only change, exclude display_info_provider_aura.cc file in
> win_aura
> > > > building.
> > > 
> > > win aura does set use_ash=1 You need to exclude this for win for now.
> > > 
> > 
> > Doesn't the statements here exclude the display_info_provider_aura.cc file?
> > It passed compiled with use_ash=1 on Windows on my local machine.
> > 
> Sorry I should have said:
> 
> You should always exclude this for win. (no need to check use_ash)
> 
> 

Done.

[oshima, 2013-09-07 05:07:07]

lgtm

[Haojian Wu, 2013-09-07 07:25:40]

On 2013/09/07 05:07:07, oshima wrote:
> lgtm

ping hongbo@.

[Haojian Wu, 2013-09-11 01:11:49]

On 2013/09/07 07:25:40, Haojian Wu wrote:
> On 2013/09/07 05:07:07, oshima wrote:
> > lgtm
> 
> ping hongbo@.

ping hongbo@ again.

[Hongbo Min, 2013-09-11 01:34:07]

lgtm

[commit-bot: I haz the power, 2013-09-11 02:09:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/Hokein.Wu@gmail.com/23876005/12001

[commit-bot: I haz the power, 2013-09-11 14:57:12]

Change committed as 222553