[Sync] Removing duplicated includes between cc and h files.

[Sync] Removing duplicated includes between cc and h files.

BUG=

Committed: https://crrev.com/453cc58ec286f2a53ac6e2c0848e6b38141943aa
Cr-Commit-Position: refs/heads/master@{#422175}

[skym, 2016-09-29 23:46:37]

The CQ bit was checked by skym@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 23:47:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[skym, 2016-09-29 23:49:02]

skym@chromium.org changed reviewers:
+ maxbogue@chromium.org

[skym, 2016-09-29 23:49:03]

PTAL, I'm still cleaning up the script to be a bit more generic, but the version
that I ran to produce this looked like the following. I then made a few manual
changes to data_type_manager and data_type_table since they contained a circular
dependency.

#!/usr/bin/env python

import os;
import re;
import collections;

target_relative_roots = ['components/sync/', 'chrome/browser/sync/',
'components/browser_sync/', 'components/sync_bookmarks/',
'components/sync_sessions/']
regex = re.compile('#include (.*?)$')

h_filename_to_include_set = {}
cc_filename_set = set()

for relative_root in target_relative_roots:
  absolute_root = os.path.join(os.getcwd(), relative_root)
  for (dirpath, dirnames, filenames) in os.walk(absolute_root):
    for filename in filenames:
      full_filepath = os.path.join(dirpath, filename)
      if os.path.splitext(filename)[1] == ".h":
        h_filename_to_include_set[full_filepath] = set()
        with open(full_filepath) as f:
          for line in f:
            match = regex.search(line)
            if match:
              h_filename_to_include_set[full_filepath].add(match.group(1))
      elif os.path.splitext(filename)[1] == ".cc":
        cc_filename_set.add(full_filepath)

for cc_filename in cc_filename_set:
  h_filename = os.path.splitext(cc_filename)[0] + ".h"
  if h_filename in h_filename_to_include_set:
    include_set = h_filename_to_include_set[h_filename]
    f = open(cc_filename,"r+")
    data = f.readlines()
    f.seek(0)
    lastCopiedLineWasEmpty = False
    lastLineWasOmitted = False
    for line in data:
        match = regex.search(line)
        if match is None or not match.group(1) in include_set:
          if lastCopiedLineWasEmpty and not line.strip() and lastLineWasOmitted:
          else:
            f.write(line)
            lastCopiedLineWasEmpty = not line.strip()
            lastLineWasOmitted = False
        else:
          lastLineWasOmitted = True
    f.truncate()
    f.close()

[commit-bot: I haz the power, 2016-09-30 01:10:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 01:10:42]

Dry run: This issue passed the CQ dry run.

[maxbogue, 2016-09-30 18:45:15]

lgtm! This is awesome. I wish we had enough infra in place that our presubmits
could ensure we only had exactly the includes that we need.

[skym, 2016-09-30 19:06:32]

The CQ bit was checked by skym@chromium.org

[commit-bot: I haz the power, 2016-09-30 19:07:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 19:18:59]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-30 19:21:50]

Description was changed from

==========
[Sync] Removing duplicated includes between cc and h files.

BUG=
==========

to

==========
[Sync] Removing duplicated includes between cc and h files.

BUG=

Committed: https://crrev.com/453cc58ec286f2a53ac6e2c0848e6b38141943aa
Cr-Commit-Position: refs/heads/master@{#422175}
==========

[commit-bot: I haz the power, 2016-09-30 19:21:51]

Patchset 2 (id:??) landed as
https://crrev.com/453cc58ec286f2a53ac6e2c0848e6b38141943aa
Cr-Commit-Position: refs/heads/master@{#422175}