Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 2387543002: Removes the extension_types property for the imageWritePrivate API. (Closed)

Created:
4 years, 2 months ago by Michael Tang
Modified:
4 years, 2 months ago
Reviewers:
Devlin, ntang
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removes the extension_types property for the imageWritePrivate API. The API already has dependency on permission:imageWritePrivate. BUG=650707 TEST=Manual. Committed: https://crrev.com/e5dfd31db3639e06ade2776c70d28b0a8ba674c7 Cr-Commit-Position: refs/heads/master@{#422834}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/common/extensions/api/_api_features.json View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
Devlin
Is this ready for review? (It's in my list, but you never published + mailed)
4 years, 2 months ago (2016-10-03 22:43:15 UTC) #3
ntang
Please review.
4 years, 2 months ago (2016-10-04 03:58:03 UTC) #5
Devlin
lgtm
4 years, 2 months ago (2016-10-04 15:05:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2387543002/1
4 years, 2 months ago (2016-10-04 16:25:32 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 17:08:53 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 17:10:45 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e5dfd31db3639e06ade2776c70d28b0a8ba674c7
Cr-Commit-Position: refs/heads/master@{#422834}

Powered by Google App Engine
This is Rietveld 408576698