Accessibility: Ignore all anonymous blocks

Accessibility: Ignore all anonymous blocks

Anonymous blocks are an implementation detail of the
Blink layout tree. They're surprising and not useful in
the accessibility tree. Get rid of them by marking them
all as ignored.

While it may seem counterintuitive, this is actually
part of a longer-term plan to get rid of the idea of
ignoring nodes for accessibility, this will bring us
closer to just exposing the DOM tree plus generated
content, like FIrefox and IE do.

The code change here is tiny, most of the change is
rebasing or updating dozens and dozens of affected
tests. I deleted a couple of tests that specifically
tested corner cases involving anonymous blocks;
the whole point of this change is to not make this a
special case anymore.

Also updates this script, designed to automatically
pull test output from try servers to a local change:

tools/accessibility/rebase_dump_accessibility_tree_test.py

BUG=651614
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/9cbd8a4019e2d4799e85d96741418d79ea046e71
Cr-Commit-Position: refs/heads/master@{#426138}

[dmazzoni, 2016-09-30 16:41:01]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 16:41:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 17:01:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 17:01:39]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[dmazzoni, 2016-10-12 15:28:50]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-12 15:29:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 15:49:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 15:49:01]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[dmazzoni, 2016-10-13 17:08:19]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 17:08:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 17:17:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 17:17:21]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dmazzoni, 2016-10-13 20:39:08]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 20:39:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 21:06:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 21:06:36]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[dmazzoni, 2016-10-13 22:13:40]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 22:13:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 22:16:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 22:16:54]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[dmazzoni, 2016-10-13 22:28:22]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 22:28:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 23:10:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 23:10:34]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[dmazzoni, 2016-10-14 07:21:35]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 07:21:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 07:48:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 07:48:19]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[dmazzoni, 2016-10-14 15:42:05]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 15:42:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 16:20:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 16:20:39]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dmazzoni, 2016-10-14 21:01:34]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 21:02:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 21:54:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 21:54:01]

Dry run: Exceeded global retry quota

[dmazzoni, 2016-10-14 23:23:41]

Description was changed from

==========
Ignore all anonymous blocks to see what breaks

Not ready for review yet

BUG=651614
==========

to

==========
Ignore all anonymous blocks to see what breaks

Not ready for review yet

BUG=651614
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dmazzoni, 2016-10-14 23:23:46]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 23:24:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-15 00:49:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-15 00:49:22]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dmazzoni, 2016-10-15 06:03:46]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-15 06:04:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-15 07:09:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-15 07:09:40]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[dmazzoni, 2016-10-17 04:48:41]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 04:48:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 05:16:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 05:16:44]

Dry run: Exceeded global retry quota

[dmazzoni, 2016-10-17 07:12:43]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 07:13:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 07:15:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 07:15:51]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[dmazzoni, 2016-10-17 07:50:24]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 07:50:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 09:30:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 09:30:32]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[dmazzoni, 2016-10-17 14:13:34]

Description was changed from

==========
Ignore all anonymous blocks to see what breaks

Not ready for review yet

BUG=651614
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Accessibility: Ignore all anonymous blocks

BUG=651614
==========

[dmazzoni, 2016-10-17 15:08:57]

Description was changed from

==========
Accessibility: Ignore all anonymous blocks

BUG=651614
==========

to

==========
Accessibility: Ignore all anonymous blocks

Anonymous blocks are an implementation detail of the
Blink layout tree. They're surprising and not useful in
the accessibility tree. Get rid of them by marking them
all as ignored.

While it may seem counterintuitive, this is actually
part of a longer-term plan to get rid of the idea of
ignoring nodes for accessibility, this will bring us
closer to just exposing the DOM tree plus generated
content, like FIrefox and IE do.

The code change here is tiny, most of the change is
rebasing or updating dozens and dozens of affected
tests. I deleted a couple of tests that specifically
tested corner cases involving anonymous blocks;
the whole point of this change is to not make this a
special case anymore.

Also updates this script, designed to automatically
pull test output from try servers to a local change:

tools/accessibility/rebase_dump_accessibility_tree_test.py

BUG=651614
==========

[dmazzoni, 2016-10-17 15:08:57]

dmazzoni@chromium.org changed reviewers:
+ aboxhall@chromium.org

[dmazzoni, 2016-10-17 15:39:07]

Description was changed from

==========
Accessibility: Ignore all anonymous blocks

Anonymous blocks are an implementation detail of the
Blink layout tree. They're surprising and not useful in
the accessibility tree. Get rid of them by marking them
all as ignored.

While it may seem counterintuitive, this is actually
part of a longer-term plan to get rid of the idea of
ignoring nodes for accessibility, this will bring us
closer to just exposing the DOM tree plus generated
content, like FIrefox and IE do.

The code change here is tiny, most of the change is
rebasing or updating dozens and dozens of affected
tests. I deleted a couple of tests that specifically
tested corner cases involving anonymous blocks;
the whole point of this change is to not make this a
special case anymore.

Also updates this script, designed to automatically
pull test output from try servers to a local change:

tools/accessibility/rebase_dump_accessibility_tree_test.py

BUG=651614
==========

to

==========
Accessibility: Ignore all anonymous blocks

Anonymous blocks are an implementation detail of the
Blink layout tree. They're surprising and not useful in
the accessibility tree. Get rid of them by marking them
all as ignored.

While it may seem counterintuitive, this is actually
part of a longer-term plan to get rid of the idea of
ignoring nodes for accessibility, this will bring us
closer to just exposing the DOM tree plus generated
content, like FIrefox and IE do.

The code change here is tiny, most of the change is
rebasing or updating dozens and dozens of affected
tests. I deleted a couple of tests that specifically
tested corner cases involving anonymous blocks;
the whole point of this change is to not make this a
special case anymore.

Also updates this script, designed to automatically
pull test output from try servers to a local change:

tools/accessibility/rebase_dump_accessibility_tree_test.py

BUG=651614
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dmazzoni, 2016-10-17 15:39:11]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 15:39:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 17:02:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 17:02:54]

Dry run: This issue passed the CQ dry run.

[dmazzoni, 2016-10-17 22:59:43]

Ready for review!

[aboxhall, 2016-10-18 20:52:59]

lgtm

[dmazzoni, 2016-10-18 22:10:07]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2016-10-18 22:10:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 00:15:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 00:15:20]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[dmazzoni, 2016-10-19 04:50:21]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2016-10-19 04:51:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 09:58:31]

Committed patchset #15 (id:280001)

[David Tseng, 2016-10-20 22:35:25]

On 2016/10/17 22:59:43, dmazzoni wrote:
> Ready for review!

This is the cause of the regression:
crbug.com/658045

Reverting.

[David Tseng, 2016-10-20 22:36:25]

A revert of this CL (patchset #15 id:280001) has been created in
https://codereview.chromium.org/2440833002/ by dtseng@chromium.org.

The reason for reverting is: crbug.com/658045.

[David Tseng, 2016-10-20 22:36:44]

A revert of this CL (patchset #15 id:280001) has been created in
https://codereview.chromium.org/2439453004/ by dtseng@chromium.org.

The reason for reverting is: crbug.com/658045.

[commit-bot: I haz the power, 2016-10-21 13:06:38]

Description was changed from

==========
Accessibility: Ignore all anonymous blocks

Anonymous blocks are an implementation detail of the
Blink layout tree. They're surprising and not useful in
the accessibility tree. Get rid of them by marking them
all as ignored.

While it may seem counterintuitive, this is actually
part of a longer-term plan to get rid of the idea of
ignoring nodes for accessibility, this will bring us
closer to just exposing the DOM tree plus generated
content, like FIrefox and IE do.

The code change here is tiny, most of the change is
rebasing or updating dozens and dozens of affected
tests. I deleted a couple of tests that specifically
tested corner cases involving anonymous blocks;
the whole point of this change is to not make this a
special case anymore.

Also updates this script, designed to automatically
pull test output from try servers to a local change:

tools/accessibility/rebase_dump_accessibility_tree_test.py

BUG=651614
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Accessibility: Ignore all anonymous blocks

Anonymous blocks are an implementation detail of the
Blink layout tree. They're surprising and not useful in
the accessibility tree. Get rid of them by marking them
all as ignored.

While it may seem counterintuitive, this is actually
part of a longer-term plan to get rid of the idea of
ignoring nodes for accessibility, this will bring us
closer to just exposing the DOM tree plus generated
content, like FIrefox and IE do.

The code change here is tiny, most of the change is
rebasing or updating dozens and dozens of affected
tests. I deleted a couple of tests that specifically
tested corner cases involving anonymous blocks;
the whole point of this change is to not make this a
special case anymore.

Also updates this script, designed to automatically
pull test output from try servers to a local change:

tools/accessibility/rebase_dump_accessibility_tree_test.py

BUG=651614
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/9cbd8a4019e2d4799e85d96741418d79ea046e71
Cr-Commit-Position: refs/heads/master@{#426138}
==========

[commit-bot: I haz the power, 2016-10-21 13:06:40]

Patchset 15 (id:??) landed as
https://crrev.com/9cbd8a4019e2d4799e85d96741418d79ea046e71
Cr-Commit-Position: refs/heads/master@{#426138}