Fold bits of SVGAnimatedTypeAnimator into SVGAnimateElement

Fold bits of SVGAnimatedTypeAnimator into SVGAnimateElement

This folds non-property-construction methods from
SVGAnimatedTypeAnimator into SVGAnimateElement and gets rid of simple
forwarding methods. This leaves SVGAnimatedTypeAnimator as a property-
value factory.

BUG=641437
Committed: https://crrev.com/40d243776ba93a704b64c372303594a4189984ac
Cr-Commit-Position: refs/heads/master@{#422188}

[fs, 2016-09-29 22:11:38]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 22:11:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 23:55:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 23:55:25]

Dry run: This issue passed the CQ dry run.

[fs, 2016-09-30 07:52:50]

fs@opera.com changed reviewers:
+ pdr@chromium.org

[pdr., 2016-09-30 19:32:19]

LGTM, comment is just a potential followup

https://codereview.chromium.org/2387513002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp (right):

https://codereview.chromium.org/2387513002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp:147:
adjustForInheritance<SVGPropertyBase*, ParsePropertyFromString>(
These are the only users of ParsePropertyFromString. Can we just remove that
class and move the logic into adjustForInheritance?

[fs, 2016-09-30 19:39:07]

https://codereview.chromium.org/2387513002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp (right):

https://codereview.chromium.org/2387513002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp:147:
adjustForInheritance<SVGPropertyBase*, ParsePropertyFromString>(
On 2016/09/30 at 19:32:19, pdr. wrote:
> These are the only users of ParsePropertyFromString. Can we just remove that
class and move the logic into adjustForInheritance?

You're way ahead of me it seems ;-) - that was going to be (one of) my next
CL(s) to this code.

[fs, 2016-09-30 19:39:13]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2016-09-30 19:39:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 19:46:33]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-30 19:50:43]

Description was changed from

==========
Fold bits of SVGAnimatedTypeAnimator into SVGAnimateElement

This folds non-property-construction methods from
SVGAnimatedTypeAnimator into SVGAnimateElement and gets rid of simple
forwarding methods. This leaves SVGAnimatedTypeAnimator as a property-
value factory.

BUG=641437
==========

to

==========
Fold bits of SVGAnimatedTypeAnimator into SVGAnimateElement

This folds non-property-construction methods from
SVGAnimatedTypeAnimator into SVGAnimateElement and gets rid of simple
forwarding methods. This leaves SVGAnimatedTypeAnimator as a property-
value factory.

BUG=641437

Committed: https://crrev.com/40d243776ba93a704b64c372303594a4189984ac
Cr-Commit-Position: refs/heads/master@{#422188}
==========

[commit-bot: I haz the power, 2016-09-30 19:50:44]

Patchset 1 (id:??) landed as
https://crrev.com/40d243776ba93a704b64c372303594a4189984ac
Cr-Commit-Position: refs/heads/master@{#422188}

[Nico, 2016-10-01 02:19:55]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2384713005/ by thakis@chromium.org.

The reason for reverting is: This is just a test, I won't land the revert..