Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Unified Diff: sdk/lib/async/future.dart

Issue 23875032: Expose Zones. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Mark stack trace test as failing. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/async/future.dart
diff --git a/sdk/lib/async/future.dart b/sdk/lib/async/future.dart
index ab4b666965b2ebfedef5d92fdf948310fe408cb8..ac2b570692fecabb67fe777cb73edb7d3c52b815 100644
--- a/sdk/lib/async/future.dart
+++ b/sdk/lib/async/future.dart
@@ -194,12 +194,15 @@ abstract class Future<T> {
// List collecting values from the futures.
// Set to null if an error occurs.
List values;
- void handleError(error) {
+
+ handleError(error) {
Lasse Reichstein Nielsen 2013/09/23 14:24:12 Without the "void" this looks too much like a func
floitsch 2013/09/23 17:12:07 It sticks nicely out in the editor. So syntax high
if (values != null) {
values = null;
completer.completeError(error);
}
+ return null;
}
+
// As each future completes, put its value into the corresponding
// position in the list of values.
int remaining = 0;

Powered by Google App Engine
This is Rietveld 408576698