ui/views/controls/menu/menu_scroll_view_container.cc - Issue 2387503002: Fix menu scroll indicators and highlights overlapping the menu border.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/menu/menu_scroll_view_container.cc

Issue 2387503002: Fix menu scroll indicators and highlights overlapping the menu border. (Closed)

Patch Set: change comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/controls/menu/menu_scroll_view_container.cc

diff --git a/ui/views/controls/menu/menu_scroll_view_container.cc b/ui/views/controls/menu/menu_scroll_view_container.cc

index cbbe72ee221720b984c3856353e56123427fb6d6..edfe737ba8f9886110cf850a5e81562dba9de4da 100644

--- a/ui/views/controls/menu/menu_scroll_view_container.cc

+++ b/ui/views/controls/menu/menu_scroll_view_container.cc

@@ -76,6 +76,8 @@ class MenuScrollButton : public View {

// The background.

gfx::Rect item_bounds(0, 0, width(), height());

+ // Avoids painting over the menu border.

+ item_bounds.Inset(views::RoundRectPainter::kBorderWidth, 0);

NativeTheme::ExtraParams extra;

GetNativeTheme()->Paint(canvas->sk_canvas(),

NativeTheme::kMenuItemBackground,