Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: runtime/vm/disassembler.cc

Issue 23875015: - Base JSON stream printing on stack objects. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/disassembler.h ('k') | runtime/vm/heap_histogram.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/disassembler.cc
===================================================================
--- runtime/vm/disassembler.cc (revision 27342)
+++ runtime/vm/disassembler.cc (working copy)
@@ -44,12 +44,11 @@
intptr_t human_size,
uword pc) {
uint8_t* pc_ptr = reinterpret_cast<uint8_t*>(pc);
- stream_->OpenObject();
- stream_->PrintProperty("type", "DisassembledInstruction");
- stream_->PrintfProperty("pc", "%p", pc_ptr);
- stream_->PrintProperty("hex", hex_buffer);
- stream_->PrintProperty("human", human_buffer);
- stream_->CloseObject();
+ JSONObject jsobj(jsarr_);
+ jsobj.AddProperty("type", "DisassembledInstruction");
+ jsobj.AddPropertyF("pc", "%p", pc_ptr);
+ jsobj.AddProperty("hex", hex_buffer);
+ jsobj.AddProperty("human", human_buffer);
}
@@ -68,10 +67,9 @@
p[i] = ' ';
}
}
- stream_->OpenObject();
- stream_->PrintProperty("type", "DisassembledInstructionComment");
- stream_->PrintProperty("comment", p);
- stream_->CloseObject();
+ JSONObject jsobj(jsarr_);
+ jsobj.AddProperty("type", "DisassembledInstructionComment");
+ jsobj.AddProperty("comment", p);
free(p);
}
« no previous file with comments | « runtime/vm/disassembler.h ('k') | runtime/vm/heap_histogram.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698