Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 23875003: Merge 219225 "Run |demuxer_| related tasks in the media thread i..." (Closed)

Created:
7 years, 3 months ago by qinmin
Modified:
7 years, 3 months ago
Reviewers:
ycheo (away)
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Merge 219225 "Run |demuxer_| related tasks in the media thread i..." > Run |demuxer_| related tasks in the media thread in GTV. > > - We found that the reading from |demuxer_| and its read-callback loops run very slowly, in the heavy load situation in the render thread. > to improve the response time of the readings, we run tasks related to |demuxer_| in the media thread. > > BUG=268208 > > Review URL: https://chromiumcodereview.appspot.com/22875030 TBR=ycheo@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220851

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+279 lines, -94 lines) Patch
M content/renderer/media/android/media_source_delegate.h View 6 chunks +44 lines, -7 lines 0 comments Download
M content/renderer/media/android/media_source_delegate.cc View 26 chunks +227 lines, -86 lines 3 comments Download
M content/renderer/media/android/webmediaplayer_android.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 2 chunks +3 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
qinmin
7 years, 3 months ago (2013-09-02 18:51:20 UTC) #1
qinmin
Committed patchset #1 manually as r220851.
7 years, 3 months ago (2013-09-02 18:53:36 UTC) #2
ycheo (away)
7 years, 3 months ago (2013-09-03 03:46:25 UTC) #3
Message was sent while issue was closed.
@Min,

I found that this merge break the build of m30 branch in Chrome for Android &
TV:
http://master.chrome.corp.google.com:8000/builders/android/builds/1555
http://master.chrome.corp.google.com:8000/builders/android-tv/builds/317

The reason is the member variable, |media_source_opened_cb_| didn't exist when
m30 branch was out.

I think some reverts of lines can fix this breakage.

https://codereview.chromium.org/23875003/diff/1/content/renderer/media/androi...
File content/renderer/media/android/media_source_delegate.cc (right):

https://codereview.chromium.org/23875003/diff/1/content/renderer/media/androi...
content/renderer/media/android/media_source_delegate.cc:160:
DCHECK(!media_source_opened_cb.is_null());
This line should be reverted to OLD-L129.

https://codereview.chromium.org/23875003/diff/1/content/renderer/media/androi...
content/renderer/media/android/media_source_delegate.cc:161:
media_source_opened_cb_ = media_source_opened_cb;
This line should be reverted to OLD-L130.

https://codereview.chromium.org/23875003/diff/1/content/renderer/media/androi...
content/renderer/media/android/media_source_delegate.cc:733: if
(media_source_opened_cb_.is_null())
This line should be reverted to OLD-L604.

Powered by Google App Engine
This is Rietveld 408576698