Correctly update enabled state of the "create managed user" checkbox.

chrome/browser/ui/webui/options/manage_profile_browsertest.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // None of these tests is relevant for Chrome OS.
 GEN('#if !defined(OS_CHROMEOS)');
 
 GEN('#include "base/command_line.h"');
 GEN('#include "chrome/common/chrome_switches.h"');
 
@@ skipping 283 matching lines @@
   assertEquals('policy', indicator.getAttribute('controlled-by'));
 
   CreateProfileOverlay.updateSignedInStatus(custodianEmail);
   CreateProfileOverlay.updateManagedUsersAllowed(true);
   assertFalse(checkbox.disabled, 're-allowed and signed in');
   assertFalse(link.hidden, 're-allowed and signed in');
   assertEquals('none', window.getComputedStyle(indicator, null).display,
                're-allowed and signed in');
 });
 
+// The managed user checkbox should correctly update its state during profile
+// creation and afterwards.
+TEST_F('ManageProfileUITest', 'CreateInProgress', function() {
+  ManageProfileOverlay.getInstance().initializePage();
+
+  var custodianEmail = 'chrome.playpen.test@gmail.com';
+  CreateProfileOverlay.updateSignedInStatus(custodianEmail);
+  CreateProfileOverlay.updateManagedUsersAllowed(true);
+  var checkbox = $('create-profile-managed');
+  var link = $('create-profile-managed-not-signed-in-link');
+  var indicator = $('create-profile-managed-indicator');
+
+  assertFalse(checkbox.disabled, 'allowed and signed in');
+  assertFalse(link.hidden, 'allowed and signed in');
+  assertEquals('none', window.getComputedStyle(indicator, null).display,
+               'allowed and signed in');
+  assertFalse(indicator.hasAttribute('controlled-by'));
+
+  CreateProfileOverlay.updateCreateInProgress(true);
+  assertTrue(checkbox.disabled, 'creation in progress');
+
+  CreateProfileOverlay.updateCreateInProgress(false);

[Pam (message me for reviews), 2013/09/05 10:08:38]

This test wouldn't have caught the bug. We must have been getting an
updateManagedUsersAllowed call while the creation was in progress.

[Bernhard Bauer, 2013/09/05 12:49:14]

Good catch! Yeah, ProfileSyncService is quite liberal with notifying about
changes, and that updates the sign-in status (to surface auth errors).

I added an additional updateSignedInStatus call, which causes the test to fail
without the fix.

+  assertFalse(checkbox.disabled, 'creation finished');
+});
+
 // Managed users shouldn't be able to open the delete or create dialogs.
 TEST_F('ManageProfileUITest', 'ManagedShowDeleteAndCreate', function() {
   this.setProfileManaged_(false);
 
   ManageProfileOverlay.showCreateDialog();
   assertEquals('createProfile', OptionsPage.getTopmostVisiblePage().name);
   OptionsPage.closeOverlay();
   assertEquals('settings', OptionsPage.getTopmostVisiblePage().name);
   ManageProfileOverlay.showDeleteDialog(this.testProfileInfo_(false));
   assertEquals('manageProfile', OptionsPage.getTopmostVisiblePage().name);
@@ skipping 35 matching lines @@
   assertEquals('settings', OptionsPage.getTopmostVisiblePage().name);
 
   ManageProfileOverlay.showDeleteDialog(this.testProfileInfo_(false));
   this.setProfileManaged_(true);
   messages = clickAndListen();
   assertEquals(0, messages.length);
   assertEquals('settings', OptionsPage.getTopmostVisiblePage().name);
 });
 
 GEN('#endif  // OS_CHROMEOS');