Correctly update enabled state of the "create managed user" checkbox.

Correctly update enabled state of the "create managed user" checkbox.

BUG=281244
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221536

[Bernhard Bauer, 2013-09-05 08:33:54]

Please review.

[Pam (message me for reviews), 2013-09-05 10:08:38]

https://codereview.chromium.org/23875002/diff/5001/chrome/browser/ui/webui/op...
File chrome/browser/ui/webui/options/manage_profile_browsertest.js (right):

https://codereview.chromium.org/23875002/diff/5001/chrome/browser/ui/webui/op...
chrome/browser/ui/webui/options/manage_profile_browsertest.js:325:
CreateProfileOverlay.updateCreateInProgress(false);
This test wouldn't have caught the bug. We must have been getting an
updateManagedUsersAllowed call while the creation was in progress.

[Bernhard Bauer, 2013-09-05 12:49:14]

https://codereview.chromium.org/23875002/diff/5001/chrome/browser/ui/webui/op...
File chrome/browser/ui/webui/options/manage_profile_browsertest.js (right):

https://codereview.chromium.org/23875002/diff/5001/chrome/browser/ui/webui/op...
chrome/browser/ui/webui/options/manage_profile_browsertest.js:325:
CreateProfileOverlay.updateCreateInProgress(false);
On 2013/09/05 10:08:38, Pam (also PM for reviews) wrote:
> This test wouldn't have caught the bug. We must have been getting an
> updateManagedUsersAllowed call while the creation was in progress.

Good catch! Yeah, ProfileSyncService is quite liberal with notifying about
changes, and that updates the sign-in status (to surface auth errors).

I added an additional updateSignedInStatus call, which causes the test to fail
without the fix.

[Pam (message me for reviews), 2013-09-05 13:04:17]

lgtm

[commit-bot: I haz the power, 2013-09-05 13:17:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bauerb@chromium.org/23875002/15001

[commit-bot: I haz the power, 2013-09-05 23:06:22]

Change committed as 221536