Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: content/public/browser/push_messaging_service.cc

Issue 2387483002: Push API: Refactor and fix unsubscribe API (Closed)
Patch Set: Added enum reuse comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/browser/push_messaging_service.h ('k') | content/public/common/push_messaging_status.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/push_messaging_service.cc
diff --git a/content/public/browser/push_messaging_service.cc b/content/public/browser/push_messaging_service.cc
index f23d1eae6c3a4f847df9225ae014854e25f139ad..de54bc9dcabd03e0f6649d831d3b3ab76aa687f2 100644
--- a/content/public/browser/push_messaging_service.cc
+++ b/content/public/browser/push_messaging_service.cc
@@ -48,7 +48,7 @@ void GetUserDataOnIO(
base::Bind(&CallStringCallbackFromIO, callback));
}
-void ClearPushSubscriptionIDOnIO(
+void ClearPushSubscriptionIdOnIO(
scoped_refptr<ServiceWorkerContextWrapper> service_worker_context,
int64_t service_worker_registration_id,
const base::Closure& callback) {
@@ -103,19 +103,17 @@ void PushMessagingService::GetSenderId(BrowserContext* browser_context,
}
// static
-void PushMessagingService::ClearPushSubscriptionID(
+void PushMessagingService::ClearPushSubscriptionId(
BrowserContext* browser_context,
const GURL& origin,
int64_t service_worker_registration_id,
const base::Closure& callback) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
BrowserThread::PostTask(
- BrowserThread::IO,
- FROM_HERE,
- base::Bind(&ClearPushSubscriptionIDOnIO,
+ BrowserThread::IO, FROM_HERE,
+ base::Bind(&ClearPushSubscriptionIdOnIO,
GetServiceWorkerContext(browser_context, origin),
- service_worker_registration_id,
- callback));
+ service_worker_registration_id, callback));
}
// static
« no previous file with comments | « content/public/browser/push_messaging_service.h ('k') | content/public/common/push_messaging_status.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698