components/gcm_driver/instance_id/fake_gcm_driver_for_instance_id.cc - Issue 2387483002: Push API: Refactor and fix unsubscribe API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/gcm_driver/instance_id/fake_gcm_driver_for_instance_id.cc

Issue 2387483002: Push API: Refactor and fix unsubscribe API (Closed)

Patch Set: Address peter's review comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/gcm_driver/instance_id/fake_gcm_driver_for_instance_id.h ('k') | content/browser/push_messaging/push_messaging_message_filter.h » ('j') | content/public/common/push_messaging_status.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/gcm_driver/instance_id/fake_gcm_driver_for_instance_id.cc

diff --git a/components/gcm_driver/instance_id/fake_gcm_driver_for_instance_id.cc b/components/gcm_driver/instance_id/fake_gcm_driver_for_instance_id.cc

index e50d55524052f040a34c3139907ba9e5e6c9c415..698329da207ca18cc37c64658ac6b33206ecac5a 100644

--- a/components/gcm_driver/instance_id/fake_gcm_driver_for_instance_id.cc

+++ b/components/gcm_driver/instance_id/fake_gcm_driver_for_instance_id.cc

@@ -85,6 +85,9 @@ void FakeGCMDriverForInstanceID::DeleteToken(

const DeleteTokenCallback& callback) {

std::string key = app_id + authorized_entity + scope;

tokens_.erase(key);

+ last_deletetoken_app_id_ = app_id;

base::ThreadTaskRunnerHandle::Get()->PostTask(

FROM_HERE, base::Bind(callback, gcm::GCMClient::SUCCESS));

}