content/shell/browser/layout_test/layout_test_push_messaging_service.h - Issue 2387483002: Push API: Refactor and fix unsubscribe API

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/shell/browser/layout_test/layout_test_push_messaging_service.h

Issue 2387483002: Push API: Refactor and fix unsubscribe API (Closed)

Patch Set: Address peter's review comments Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/public/common/push_messaging_status.h ('K') | « content/public/common/push_messaging_status.h ('k') | content/shell/browser/layout_test/layout_test_push_messaging_service.cc » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CONTENT_SHELL_BROWSER_LAYOUT_TEST_LAYOUT_TEST_PUSH_MESSAGING_SERVICE_H_	5 #ifndef CONTENT_SHELL_BROWSER_LAYOUT_TEST_LAYOUT_TEST_PUSH_MESSAGING_SERVICE_H_

6 #define CONTENT_SHELL_BROWSER_LAYOUT_TEST_LAYOUT_TEST_PUSH_MESSAGING_SERVICE_H_	6 #define CONTENT_SHELL_BROWSER_LAYOUT_TEST_LAYOUT_TEST_PUSH_MESSAGING_SERVICE_H_

7	7

8 #include <stdint.h>	8 #include <stdint.h>

9	9

10 #include <map>	10 #include <map>

(...skipping 35 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
46 blink::WebPushPermissionStatus GetPermissionStatus(const GURL& origin,	46 blink::WebPushPermissionStatus GetPermissionStatus(const GURL& origin,

47 bool user_visible)	47 bool user_visible)

48 override;	48 override;

49 bool SupportNonVisibleMessages() override;	49 bool SupportNonVisibleMessages() override;

50 void Unsubscribe(const GURL& requesting_origin,	50 void Unsubscribe(const GURL& requesting_origin,

51 int64_t service_worker_registration_id,	51 int64_t service_worker_registration_id,

52 const std::string& sender_id,	52 const std::string& sender_id,

53 const UnregisterCallback& callback) override;	53 const UnregisterCallback& callback) override;

54	54

55 private:	55 private:

	56 bool is_subscribed_ = false;

	57

56 DISALLOW_COPY_AND_ASSIGN(LayoutTestPushMessagingService);	58 DISALLOW_COPY_AND_ASSIGN(LayoutTestPushMessagingService);

57 };	59 };

58	60

59 } // namespace content	61 } // namespace content

60	62

61 #endif // CONTENT_SHELL_BROWSER_LAYOUT_TEST_LAYOUT_TEST_PUSH_MESSAGING_SERVICE_ H_	63 #endif // CONTENT_SHELL_BROWSER_LAYOUT_TEST_LAYOUT_TEST_PUSH_MESSAGING_SERVICE_ H_

OLD	NEW