Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 2387453002: Use system download completion notification if app notification is disabled. (Closed)

Created:
4 years, 2 months ago by qinmin
Modified:
4 years, 2 months ago
Reviewers:
gone
CC:
chromium-reviews, asanka, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use system download completion notification if app notification is disabled. Because all download now goes through Chrome, user will not see notification if app notification is disabled. This change allows us to use system DownloadManager to display the completion notification, in case app notification is disabled. BUG=648221 Committed: https://crrev.com/b9d324d288c1d36ae14398e367e0abfa15e97075 Cr-Commit-Position: refs/heads/master@{#421959}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerDelegate.java View 4 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
qinmin
PTAL
4 years, 2 months ago (2016-09-29 20:45:33 UTC) #2
gone
lgtm
4 years, 2 months ago (2016-09-29 21:00:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2387453002/1
4 years, 2 months ago (2016-09-29 21:50:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-29 22:30:47 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 22:39:55 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b9d324d288c1d36ae14398e367e0abfa15e97075
Cr-Commit-Position: refs/heads/master@{#421959}

Powered by Google App Engine
This is Rietveld 408576698