Merge ExtensionImpl into EventBindings.

Merge ExtensionImpl into EventBindings.

There's a TODO to do this and it got in my way today so may as well fix it.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264163

[not at google - send to devlin, 2014-04-15 16:44:11]

could you point out what changed, if anything? rietveld gives a very useless
diff.

https://codereview.chromium.org/238743002/diff/1/chrome/renderer/extensions/e...
File chrome/renderer/extensions/event_bindings.h (right):

https://codereview.chromium.org/238743002/diff/1/chrome/renderer/extensions/e...
chrome/renderer/extensions/event_bindings.h:23: class EventBindings : public
ChromeV8Extension {
Ideally you should extend ObjectBackedNativeHandler. ChromeV8Extension offers
almost nothing over it (and it would be very nice to delete it and remove that
unnecessary layer).

Instead of GetRenderView() you'd use context()->GetRenderView() etc.

https://codereview.chromium.org/238743002/diff/1/chrome/renderer/extensions/e...
chrome/renderer/extensions/event_bindings.h:30: void AttachEvent(const
v8::FunctionCallbackInfo<v8::Value>& args);
can these be private?

[koz (OOO until 15th September), 2014-04-15 23:36:57]

No logic changed - it's just pulling out a declaration of the class into the .h.

https://codereview.chromium.org/238743002/diff/1/chrome/renderer/extensions/e...
File chrome/renderer/extensions/event_bindings.h (right):

https://codereview.chromium.org/238743002/diff/1/chrome/renderer/extensions/e...
chrome/renderer/extensions/event_bindings.h:23: class EventBindings : public
ChromeV8Extension {
On 2014/04/15 16:44:11, kalman wrote:
> Ideally you should extend ObjectBackedNativeHandler. ChromeV8Extension offers
> almost nothing over it (and it would be very nice to delete it and remove that
> unnecessary layer).
> 
> Instead of GetRenderView() you'd use context()->GetRenderView() etc.

Done.

https://codereview.chromium.org/238743002/diff/1/chrome/renderer/extensions/e...
chrome/renderer/extensions/event_bindings.h:30: void AttachEvent(const
v8::FunctionCallbackInfo<v8::Value>& args);
On 2014/04/15 16:44:11, kalman wrote:
> can these be private?

Done.

[not at google - send to devlin, 2014-04-15 23:45:01]

lgtm

[koz (OOO until 15th September), 2014-04-16 00:57:06]

The CQ bit was checked by koz@chromium.org

[commit-bot: I haz the power, 2014-04-16 00:57:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/koz@chromium.org/238743002/40001

[commit-bot: I haz the power, 2014-04-16 01:37:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/koz@chromium.org/238743002/40001

[commit-bot: I haz the power, 2014-04-16 09:48:45]

Change committed as 264163