Update WebView manifest for API 24.

Update WebView manifest for API 24.

The sandboxed renderer service must be defined as an external service
for multiprocess to work; this was only being set via a downstream jinja
variable override. Remove the jinja variable as it's not used for
anything else, and just always set externalService to true. Also, target
API 24 by default.

BUG=643660
Committed: https://crrev.com/59981e3bcf550b3db4c0d7f6f0953c873626fb70
Cr-Commit-Position: refs/heads/master@{#423185}

[Torne, 2016-10-05 15:59:09]

Description was changed from

==========
Set externalService="true" for multiprocess WebView.

The sandboxed renderer service must be defined as an external service
for multiprocess to work; this was only being set via a downstream jinja
variable override. Remove the jinja variable as it's not used for
anything else, and just always set externalService to true.

BUG=643660
==========

to

==========
Update WebView manifest for API 24.

The sandboxed renderer service must be defined as an external service
for multiprocess to work; this was only being set via a downstream jinja
variable override. Remove the jinja variable as it's not used for
anything else, and just always set externalService to true. Also, target
API 24 by default.

BUG=643660
==========

[Torne, 2016-10-05 15:59:25]

torne@chromium.org changed reviewers:
+ boliu@chromium.org, michaelbai@chromium.org

[boliu, 2016-10-05 16:01:52]

doesn't this need to wait for sdk roll?

[Torne, 2016-10-05 16:07:57]

On 2016/10/05 16:01:52, boliu wrote:
> doesn't this need to wait for sdk roll?

Does it? I can build locally with this, without setting any of the internal
build variables. You already rolled the system SDK, and that's all that matters
to build WebView as far as I can tell.

[Torne, 2016-10-05 16:08:03]

The CQ bit was checked by torne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 16:08:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[boliu, 2016-10-05 16:14:18]

On 2016/10/05 16:07:57, Torne wrote:
> On 2016/10/05 16:01:52, boliu wrote:
> > doesn't this need to wait for sdk roll?
> 
> Does it? I can build locally with this, without setting any of the internal
> build variables. You already rolled the system SDK, and that's all that
matters
> to build WebView as far as I can tell.

Ahh, you are right. system_webview_apk at least the final step is built the
system sdk.

lgtm

[commit-bot: I haz the power, 2016-10-05 16:29:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 16:29:41]

Dry run: This issue passed the CQ dry run.

[Torne, 2016-10-05 16:34:25]

The CQ bit was checked by torne@chromium.org

[commit-bot: I haz the power, 2016-10-05 16:34:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 16:40:43]

Description was changed from

==========
Update WebView manifest for API 24.

The sandboxed renderer service must be defined as an external service
for multiprocess to work; this was only being set via a downstream jinja
variable override. Remove the jinja variable as it's not used for
anything else, and just always set externalService to true. Also, target
API 24 by default.

BUG=643660
==========

to

==========
Update WebView manifest for API 24.

The sandboxed renderer service must be defined as an external service
for multiprocess to work; this was only being set via a downstream jinja
variable override. Remove the jinja variable as it's not used for
anything else, and just always set externalService to true. Also, target
API 24 by default.

BUG=643660
==========

[commit-bot: I haz the power, 2016-10-05 16:40:44]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-05 16:42:27]

Description was changed from

==========
Update WebView manifest for API 24.

The sandboxed renderer service must be defined as an external service
for multiprocess to work; this was only being set via a downstream jinja
variable override. Remove the jinja variable as it's not used for
anything else, and just always set externalService to true. Also, target
API 24 by default.

BUG=643660
==========

to

==========
Update WebView manifest for API 24.

The sandboxed renderer service must be defined as an external service
for multiprocess to work; this was only being set via a downstream jinja
variable override. Remove the jinja variable as it's not used for
anything else, and just always set externalService to true. Also, target
API 24 by default.

BUG=643660

Committed: https://crrev.com/59981e3bcf550b3db4c0d7f6f0953c873626fb70
Cr-Commit-Position: refs/heads/master@{#423185}
==========

[commit-bot: I haz the power, 2016-10-05 16:42:28]

Patchset 2 (id:??) landed as
https://crrev.com/59981e3bcf550b3db4c0d7f6f0953c873626fb70
Cr-Commit-Position: refs/heads/master@{#423185}