Source/core/rendering/RenderTableSection.cpp - Issue 23874023: Heap-buffer-overflow in void std::__final_insertion_sort.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderTableSection.cpp

Issue 23874023: Heap-buffer-overflow in void std::__final_insertion_sort. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/table/table-rowspan-crash-with-huge-rowspan-cells-2.html ('K') | « LayoutTests/fast/table/table-rowspan-crash-with-huge-rowspan-cells-2-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderTableSection.cpp

diff --git a/Source/core/rendering/RenderTableSection.cpp b/Source/core/rendering/RenderTableSection.cpp

index 4845ec9a454442c85dd298c705dbaa761a276494..b5e77a063205e9a62207401ef81466cc62ad1423 100644

--- a/Source/core/rendering/RenderTableSection.cpp

+++ b/Source/core/rendering/RenderTableSection.cpp

@@ -414,7 +414,7 @@ static bool compareRowSpanCellsInHeightDistributionOrder(const RenderTableCell*

return true;

// Sorting lower row index first because first we need to apply the extra height of spanning cell which

// comes first in the table so lower rows's position would increment in sequence.

- if (cellIsFullyIncludedInOtherCell(cell2, cell1))

+ if (!cellIsFullyIncludedInOtherCell(cell2, cell1))

return (cell1->rowIndex() < cell2->rowIndex());

return false;