Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Unified Diff: Source/core/animation/CompositorAnimations.h

Issue 23874019: Web Animations CSS: Start running animations on the compositor (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/animation/CompositorAnimations.h
diff --git a/Source/core/animation/CompositorAnimations.h b/Source/core/animation/CompositorAnimations.h
index ff41163cf056244709117cc68f10839aaf2f4e42..beafe2043180c115d244a1c68ea11b67c72882f3 100644
--- a/Source/core/animation/CompositorAnimations.h
+++ b/Source/core/animation/CompositorAnimations.h
@@ -60,7 +60,8 @@ public:
virtual bool isCandidateForCompositorAnimation(const Timing&, const AnimationEffect&);
virtual bool canStartCompositorAnimation(const Element&);
- virtual void startCompositorAnimation(const Element&, const Timing&, const AnimationEffect&, Vector<int>& startedAnimationIds);
+ // FIXME: This should return void. We should know ahead of time whether these animations can be started.
+ virtual bool startCompositorAnimation(const Element&, const Timing&, const AnimationEffect&, Vector<int>& startedAnimationIds);
shans 2013/11/18 01:02:06 Plus One. Should this FIXME be in Animation.h too?
dstockwell 2013/11/18 05:30:34 I think it's fine to just have it here, if this is
virtual void cancelCompositorAnimation(const Element&, int id);
protected:

Powered by Google App Engine
This is Rietveld 408576698