Chromium Code Reviews| Index: Source/core/animation/CompositorAnimations.h |
| diff --git a/Source/core/animation/CompositorAnimations.h b/Source/core/animation/CompositorAnimations.h |
| index ff41163cf056244709117cc68f10839aaf2f4e42..beafe2043180c115d244a1c68ea11b67c72882f3 100644 |
| --- a/Source/core/animation/CompositorAnimations.h |
| +++ b/Source/core/animation/CompositorAnimations.h |
| @@ -60,7 +60,8 @@ public: |
| virtual bool isCandidateForCompositorAnimation(const Timing&, const AnimationEffect&); |
| virtual bool canStartCompositorAnimation(const Element&); |
| - virtual void startCompositorAnimation(const Element&, const Timing&, const AnimationEffect&, Vector<int>& startedAnimationIds); |
| + // FIXME: This should return void. We should know ahead of time whether these animations can be started. |
| + virtual bool startCompositorAnimation(const Element&, const Timing&, const AnimationEffect&, Vector<int>& startedAnimationIds); |
|
shans
2013/11/18 01:02:06
Plus One. Should this FIXME be in Animation.h too?
dstockwell
2013/11/18 05:30:34
I think it's fine to just have it here, if this is
|
| virtual void cancelCompositorAnimation(const Element&, int id); |
| protected: |