Source/core/animation/CompositorAnimations.h - Issue 23874019: Web Animations CSS: Start running animations on the compositor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/CompositorAnimations.h

Issue 23874019: Web Animations CSS: Start running animations on the compositor (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/animation/CompositorAnimations.h

diff --git a/Source/core/animation/CompositorAnimations.h b/Source/core/animation/CompositorAnimations.h

index ff41163cf056244709117cc68f10839aaf2f4e42..beafe2043180c115d244a1c68ea11b67c72882f3 100644

--- a/Source/core/animation/CompositorAnimations.h

+++ b/Source/core/animation/CompositorAnimations.h

@@ -60,7 +60,8 @@ public:

virtual bool isCandidateForCompositorAnimation(const Timing&, const AnimationEffect&);

virtual bool canStartCompositorAnimation(const Element&);

- virtual void startCompositorAnimation(const Element&, const Timing&, const AnimationEffect&, Vector<int>& startedAnimationIds);

+ // FIXME: This should return void. We should know ahead of time whether these animations can be started.

+ virtual bool startCompositorAnimation(const Element&, const Timing&, const AnimationEffect&, Vector<int>& startedAnimationIds);

virtual void cancelCompositorAnimation(const Element&, int id);

protected: