Source/core/animation/AnimationEffect.h - Issue 23874019: Web Animations CSS: Start running animations on the compositor

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/animation/AnimationEffect.h

Issue 23874019: Web Animations CSS: Start running animations on the compositor (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Cleanup isRunning* and shouldCompositeForAnimation Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2013 Google Inc. All rights reserved.	2 * Copyright (C) 2013 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 42 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
53 public:	53 public:

54 virtual ~CompositableValue() { }	54 virtual ~CompositableValue() { }

55 virtual bool dependsOnUnderlyingValue() const = 0;	55 virtual bool dependsOnUnderlyingValue() const = 0;

56 virtual PassRefPtr<AnimatableValue> compositeOnto(const AnimatableValue* ) const = 0;	56 virtual PassRefPtr<AnimatableValue> compositeOnto(const AnimatableValue* ) const = 0;

57 };	57 };

58	58

59 virtual ~AnimationEffect() { }	59 virtual ~AnimationEffect() { }

60 typedef HashMap<CSSPropertyID, RefPtr<CompositableValue> > CompositableValue Map;	60 typedef HashMap<CSSPropertyID, RefPtr<CompositableValue> > CompositableValue Map;

61 virtual PassOwnPtr<CompositableValueMap> sample(int iteration, double fracti on) const = 0;	61 virtual PassOwnPtr<CompositableValueMap> sample(int iteration, double fracti on) const = 0;

62	62

	63 virtual bool affects(CSSPropertyID) { return false; };
	Steve Block 2013/11/18 05:03:03 It looks like my comment in Animation::affects() i It looks like my comment in Animation::affects() is moot. I guess you don't need toKeyframeAnimationEffect() there. dstockwell 2013/11/18 06:11:20 Done. Show quoted text On 2013/11/18 05:03:03, Steve Block wrote: > It looks like my comment in Animation::affects() is moot. I guess you don't need > toKeyframeAnimationEffect() there. Done.
63 virtual bool isKeyframeAnimationEffect() const { return false; }	64 virtual bool isKeyframeAnimationEffect() const { return false; }

64 };	65 };

65	66

66 } // namespace WebCore	67 } // namespace WebCore

67	68

68 #endif // AnimationEffect_h	69 #endif // AnimationEffect_h

OLD	NEW

« Source/core/animation/Animation.cpp ('K') | « Source/core/animation/Animation.cpp ('k') | Source/core/animation/AnimationStack.h » ('j') | Source/core/animation/DocumentTimeline.cpp » ('J')