Web Animations CSS: Start running animations on the compositor

Source/core/animation/Animation.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 27 matching lines @@
 namespace WebCore {
 
 class Element;
 
 class Animation FINAL : public TimedItem {
 
 public:
     enum Priority { DefaultPriority, TransitionPriority };
 
     static PassRefPtr<Animation> create(PassRefPtr<Element>, PassRefPtr<AnimationEffect>, const Timing&, Priority = DefaultPriority, PassOwnPtr<EventDelegate> = nullptr);
+    virtual bool isAnimation() OVERRIDE FINAL { return true; }
 
     const AnimationEffect::CompositableValueMap* compositableValues() const
     {
         ASSERT(m_compositableValues);
         return m_compositableValues.get();
     }
 
+    bool affects(CSSPropertyID property) const;
     const AnimationEffect* effect() const { return m_effect.get(); }
     Priority priority() const { return m_priority; }
 
+    bool isCandidateForCompositorAnimation() const;
+    bool startCompositorAnimations();
+    bool isRunningCompositorAnimation() const;
+    bool isRunningCompositorAnimation(CSSPropertyID) const;
+    void cancelCompositorAnimations();

[Steve Block, 2013/11/18 05:03:03]

The use of 'Animation' here seems awkward given the class name. I guess the
problem is that a single 'Animation' can map to several 'compositor animations'.
I'm not sure I can think of better names though.

Perhaps we should just make isCandidateForCompositorAnimations() and
isRunningCompositorAnimations() plural to make it more clear?

[dstockwell, 2013/11/18 06:11:20]

I've made everything plural for now.

+
 protected:
     // Returns whether style recalc was triggered.
     virtual bool applyEffects(bool previouslyInEffect);
     virtual void clearEffects();
     virtual bool updateChildrenAndEffects() const OVERRIDE FINAL;
     virtual void didAttach() OVERRIDE FINAL;
     virtual void willDetach() OVERRIDE FINAL;
     virtual double calculateTimeToEffectChange(double inheritedTime, double timeToNextIteration) const OVERRIDE FINAL;
 
 private:
     Animation(PassRefPtr<Element>, PassRefPtr<AnimationEffect>, const Timing&, Priority, PassOwnPtr<EventDelegate>);
 
     RefPtr<Element> m_target;
     RefPtr<AnimationEffect> m_effect;
 
     bool m_activeInAnimationStack;
     OwnPtr<AnimationEffect::CompositableValueMap> m_compositableValues;
 
     Priority m_priority;
+
+    Vector<int> m_acceleratedAnimationIds;

[Steve Block, 2013/11/18 05:03:03]

We should be consistent with naming: 'compositorAnimation' vs
'acceleratedAnimation'.

Also probably warrants a comment.

[dstockwell, 2013/11/18 06:11:20]

Done.

 };
 
+inline Animation* toAnimation(TimedItem* timedItem)
+{
+    ASSERT_WITH_SECURITY_IMPLICATION(timedItem && timedItem->isAnimation());
+    return static_cast<Animation*>(timedItem);
+}
+
 } // namespace WebCore
 
 #endif