Web Animations CSS: Start running animations on the compositor

Source/core/animation/Animation.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 14 matching lines @@
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 #include "core/animation/Animation.h"
 
 #include "core/animation/ActiveAnimations.h"
+#include "core/animation/CompositorAnimations.h"
+#include "core/animation/KeyframeAnimationEffect.h"
 #include "core/animation/Player.h"
 #include "core/dom/Element.h"
 
 namespace WebCore {
 
 PassRefPtr<Animation> Animation::create(PassRefPtr<Element> target, PassRefPtr<AnimationEffect> effect, const Timing& timing, Priority priority, PassOwnPtr<EventDelegate> eventDelegate)
 {
     return adoptRef(new Animation(target, effect, timing, priority, eventDelegate));
 }
 
 Animation::Animation(PassRefPtr<Element> target, PassRefPtr<AnimationEffect> effect, const Timing& timing, Priority priority, PassOwnPtr<EventDelegate> eventDelegate)
     : TimedItem(timing, eventDelegate)
     , m_target(target)
     , m_effect(effect)
     , m_activeInAnimationStack(false)
     , m_priority(priority)
 {
 }
 
 void Animation::didAttach()
 {
     if (m_target)
         m_target->ensureActiveAnimations()->players().add(player());
 }
 
 void Animation::willDetach()
 {
     if (m_target)
         m_target->activeAnimations()->players().remove(player());
-
     if (m_activeInAnimationStack)
         clearEffects();
 }
 
 static AnimationStack& ensureAnimationStack(Element* element)
 {
     return element->ensureActiveAnimations()->defaultStack();
 }
 
 bool Animation::applyEffects(bool previouslyInEffect)
@@ skipping 10 matching lines @@
     m_compositableValues = m_effect->sample(currentIteration(), timeFraction());
     m_target->setNeedsStyleRecalc(LocalStyleChange, StyleChangeFromRenderer);
     return true;
 }
 
 void Animation::clearEffects()
 {
     ASSERT(player());
     ASSERT(m_activeInAnimationStack);
     ensureAnimationStack(m_target.get()).remove(this);
+    cancelCompositorAnimations();
     m_activeInAnimationStack = false;
     m_compositableValues.clear();
     m_target->setNeedsStyleRecalc(LocalStyleChange, StyleChangeFromRenderer);
 }
 
 bool Animation::updateChildrenAndEffects() const
 {
     if (!m_effect)
         return false;
 
     if (isInEffect())
         return const_cast<Animation*>(this)->applyEffects(m_activeInAnimationStack);
 
     if (m_activeInAnimationStack) {
         const_cast<Animation*>(this)->clearEffects();
         return true;
     }
     return false;
 }
 
-double Animation::calculateTimeToEffectChange(double localTime, double) const
+double Animation::calculateTimeToEffectChange(double localTime, double timeToNextIteration) const
 {
     const double activeStartTime = startTime() + specified().startDelay;
-
     switch (phase()) {
     case PhaseBefore:
         return activeStartTime - localTime;
     case PhaseActive:
+        if (isRunningCompositorAnimation()) {
+            // Need service to apply fill / fire events.
+            const double activeEndTime = activeStartTime + activeDuration();
+            return isNull(timeToNextIteration) ? activeEndTime - localTime : timeToNextIteration;

[Steve Block, 2013/11/18 05:03:03]

Does this assume that timeToNextIteration is always <= the time to the end of
the animation? Can we assert this?

[dstockwell, 2013/11/18 06:11:20]

Done.

+        }
         return 0;
     case PhaseAfter:
         // If this Animation is still in effect then it will need to update
         // when its parent goes out of effect. We have no way of knowing when
         // that will be, however, so the parent will need to supply it.
         return std::numeric_limits<double>::infinity();
     case PhaseNone:
     default:
         ASSERT_NOT_REACHED();
         return 0;
     }
 }
 
+bool Animation::isCandidateForCompositorAnimation() const
+{
+    if (!effect() || !m_target)
+        return false;
+    return CompositorAnimations::instance()->isCandidateForCompositorAnimation(specified(), *effect());
+}
+
+bool Animation::startCompositorAnimations()
+{
+    ASSERT(!isRunningCompositorAnimation());
+    if (!isCandidateForCompositorAnimation())
+        return false;
+    if (!CompositorAnimations::instance()->canStartCompositorAnimation(*m_target.get()))
+        return false;
+    if (CompositorAnimations::instance()->startCompositorAnimation(*m_target.get(), specified(), *effect(), m_acceleratedAnimationIds)) {

[Steve Block, 2013/11/18 05:03:03]

Given that startCompositorAnimation() returns a vector of animation IDs, the
name really should be plural.

[dstockwell, 2013/11/18 06:11:20]

Done.

+        ASSERT(!m_acceleratedAnimationIds.isEmpty());
+        return true;

[Steve Block, 2013/11/18 05:03:03]

Can you invert this 'if' to make all the early-outs 'false'.

[dstockwell, 2013/11/18 06:11:20]

Done.

+    }
+    return false;
+}
+
+bool Animation::isRunningCompositorAnimation() const
+{
+    return !m_acceleratedAnimationIds.isEmpty();
+}
+
+bool Animation::isRunningCompositorAnimation(CSSPropertyID property) const
+{
+    return isRunningCompositorAnimation() && affects(property);
+}
+
+bool Animation::affects(CSSPropertyID property) const
+{
+    return toKeyframeAnimationEffect(m_effect.get())->affects(property);

[Steve Block, 2013/11/18 05:03:03]

Hmm, why isn't affects() on AnimationEffect, rather than just
KeyframeAnimationEffect? It seems like the concept makes sense for any effect.

I guess that for CSS, we only need to consider KAE, but most of the Web
Animations model logic supports the general case. I think we should at least
have a comment somewhere explaining what doesn't support the general case.

[dstockwell, 2013/11/18 06:11:20]

Done.

+}
+
+void Animation::cancelCompositorAnimations()
+{
+    if (!isRunningCompositorAnimation())
+        return;
+    if (!m_target || !m_target->renderer())
+        return;
+    for (size_t i = 0; i < m_acceleratedAnimationIds.size(); ++i) {
+        CompositorAnimations::instance()->cancelCompositorAnimation(*m_target.get(), m_acceleratedAnimationIds[i]);
+    }
+    m_acceleratedAnimationIds.clear();
+}
+
 } // namespace WebCore