chrome/browser/extensions/extension_browsertest_util.h - Issue 23874006: Add a function to send scripts from a browsertest to an extension's background page.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/extension_browsertest_util.h

Issue 23874006: Add a function to send scripts from a browsertest to an extension's background page. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/extensions/api/declarative_content/declarative_content_apitest.cc ('k') | chrome/browser/extensions/extension_browsertest_util.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_BROWSERTEST_UTIL_H_

	6 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_BROWSERTEST_UTIL_H_
	not at google - send to devlin 2013/09/03 23:13:38 just browsertest_util? just browsertest_util? Jeffrey Yasskin 2013/09/03 23:33:13 Sure, done. Show quoted text On 2013/09/03 23:13:38, kalman wrote: > just browsertest_util? Sure, done.
	7

	8 #include <string>

	9

	10 class Profile;

	11

	12 namespace extensions {

	13
	not at google - send to devlin 2013/09/03 23:13:38 can we put this file in a browsertest_util namespa can we put this file in a browsertest_util namespace? Jeffrey Yasskin 2013/09/03 23:33:13 After some discussion about a 'testing' namespace Show quoted text On 2013/09/03 23:13:38, kalman wrote: > can we put this file in a browsertest_util namespace? After some discussion about a 'testing' namespace (downside: using gtest and gmock facilities inside the extensions namespace would now require writing "::testing"), we agree to use browsertest_util, to help people reading code figure out what file to look in to find these functions.
	14 // Waits until \|script\| calls "window.domAutomationController.send('string')"
	not at google - send to devlin 2013/09/03 23:13:38 what is 'string'? what is 'string'? Jeffrey Yasskin 2013/09/03 23:33:13 How's the new comment? Show quoted text On 2013/09/03 23:13:38, kalman wrote: > what is 'string'? How's the new comment?
	15 // and returns the string. Fails the test and returns an empty string if

	16 // \|extension_id\| isn't installed in \|profile\| or doesn't have a background

	17 // page, or if executing the script fails.

	18 std::string ExecuteScriptInBackgroundPage(Profile* profile,

	19 const std::string& extension_id,

	20 const std::string& script);

	21

	22 } // namespace extensions

	23

	24 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_BROWSERTEST_UTIL_H_

OLD	NEW