Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Unified Diff: chrome/common/ntp_logging_events.h

Issue 23874005: Ensure the 1993 NTP logs to UMA Most Visited tiles that use the fallback thumbnail instead of the p… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Answered asvitkine comments Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/ntp/ntp_user_data_logger.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/ntp_logging_events.h
diff --git a/chrome/common/ntp_logging_events.h b/chrome/common/ntp_logging_events.h
index 3a95a59932fd4cc6155fd6c9f44e6e4600ffa210..8bc8738b7fb08347b4999bbec76ef752757195ba 100644
--- a/chrome/common/ntp_logging_events.h
+++ b/chrome/common/ntp_logging_events.h
@@ -13,9 +13,18 @@ enum NTPLoggingEventType {
// The page attempted to load a thumbnail image.
NTP_THUMBNAIL_ATTEMPT = 1,
- // There was an error in loading a thumbnail image.
+ // There was an error in loading both the thumbnail image and the fallback
+ // (if it was provided), resulting in a grey tile.
NTP_THUMBNAIL_ERROR = 2,
+ // The page attempted to load a thumbnail URL while a fallback thumbnail was
+ // provided.
+ NTP_FALLBACK_THUMBNAIL_REQUESTED = 3,
+
+ // The primary thumbnail image failed to load and caused us to use the
+ // secondary thumbnail as a fallback.
+ NTP_FALLBACK_THUMBNAIL_USED = 4,
+
NTP_NUM_EVENT_TYPES
};
« no previous file with comments | « chrome/browser/ui/webui/ntp/ntp_user_data_logger.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698