Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3748)

Unified Diff: chrome/browser/resources/local_ntp/most_visited_thumbnail.js

Issue 23874005: Ensure the 1993 NTP logs to UMA Most Visited tiles that use the fallback thumbnail instead of the p… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Answered asvitkine comments Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/local_ntp/most_visited_util.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/local_ntp/most_visited_thumbnail.js
diff --git a/chrome/browser/resources/local_ntp/most_visited_thumbnail.js b/chrome/browser/resources/local_ntp/most_visited_thumbnail.js
index 8952d70afa0f96be8442e3e61b9c752d7e85d707..dd3f4fddf4e9bb2cde016784610a695ea3b12227 100644
--- a/chrome/browser/resources/local_ntp/most_visited_thumbnail.js
+++ b/chrome/browser/resources/local_ntp/most_visited_thumbnail.js
@@ -51,9 +51,11 @@ window.addEventListener('DOMContentLoaded', function() {
// The first thumbnail's onerror function will swap the visibility of
// the two thumbnails.
image.onerror = function() {
+ logEvent(NTP_LOGGING_EVENT_TYPE.NTP_FALLBACK_THUMBNAIL_USED);
image.style.visibility = 'hidden';
image2.style.visibility = 'visible';
};
+ logEvent(NTP_LOGGING_EVENT_TYPE.NTP_FALLBACK_THUMBNAIL_REQUESTED);
} else {
image.onerror = showDomainElement;
}
« no previous file with comments | « no previous file | chrome/browser/resources/local_ntp/most_visited_util.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698