chrome/browser/resources/local_ntp/most_visited_util.js - Issue 23874005: Ensure the 1993 NTP logs to UMA Most Visited tiles that use the fallback thumbnail instead of the p…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/local_ntp/most_visited_util.js

Issue 23874005: Ensure the 1993 NTP logs to UMA Most Visited tiles that use the fallback thumbnail instead of the p… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Change to histograms.xml Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/local_ntp/most_visited_thumbnail.js ('k') | chrome/browser/ui/webui/ntp/ntp_user_data_logger.h » ('j') | chrome/browser/ui/webui/ntp/ntp_user_data_logger.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/local_ntp/most_visited_util.js

diff --git a/chrome/browser/resources/local_ntp/most_visited_util.js b/chrome/browser/resources/local_ntp/most_visited_util.js

index 446b7ca20e67b94c4491bc30b19f6c02bc538b35..3e058bcc3979361055ac94119b9065fa0d144ed3 100644

--- a/chrome/browser/resources/local_ntp/most_visited_util.js

+++ b/chrome/browser/resources/local_ntp/most_visited_util.js

@@ -19,8 +19,15 @@ var NTP_LOGGING_EVENT_TYPE = {

NTP_MOUSEOVER: 0,

// The page attempted to load a thumbnail image.

NTP_THUMBNAIL_ATTEMPT: 1,

- // There was an error in loading a thumbnail image.

- NTP_THUMBNAIL_ERROR: 2

+ // There was an error in loading both the thumbnail image and the fallback

+ // (if it was provided), resulting in a grey tile.

+ NTP_THUMBNAIL_ERROR: 2,

+ // The page attempted to load a thumbnail URL while a fallback thumbnail was

+ // provided.

+ NTP_FALLBACK_THUMBNAIL_REQUESTED: 3,

+ // The primary thumbnail image failed to load and caused us to use the

+ // secondary thumbnail as a fallback.

+ NTP_FALLBACK_THUMBNAIL_USED: 4

};

/**