Ensure the 1993 NTP logs to UMA Most Visited tiles that use the fallback thumbnail instead of the p…

chrome/browser/resources/local_ntp/most_visited_util.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 
 /**
  * @fileoverview Utilities for rendering most visited thumbnails and titles.
  */
 
 <include src="instant_iframe_validation.js">
 
 /**
  * Enum for the different types of events that are logged from the NTP.
  * @enum {number}
  * @const
  */
 var NTP_LOGGING_EVENT_TYPE = {
   // The user moused over an NTP tile or title.
   NTP_MOUSEOVER: 0,
   // The page attempted to load a thumbnail image.
   NTP_THUMBNAIL_ATTEMPT: 1,
   // There was an error in loading a thumbnail image.

[Mathieu, 2013/09/03 21:40:23]

nit: update comment to mention this is the ultimate failure -- a grey tile.

[beaudoin, 2013/09/03 22:34:55]

Done.

[jeremycho, 2013/09/04 20:53:57]

Not done?

[beaudoin, 2013/09/05 12:47:32]

Done.

-  NTP_THUMBNAIL_ERROR: 2
+  NTP_THUMBNAIL_ERROR: 2,
+  // The page attempted to load a thumbnail image and provided a fallback.

[Mathieu, 2013/09/03 21:40:23]

// The page was provided a fallback thumbnail URL, loaded at the same time as
the primary thumbnail URL.

[beaudoin, 2013/09/03 22:34:55]

Rephrased a little.

Done.

[beaudoin, 2013/09/05 12:47:32]

Done done.

+  NTP_THUMBNAIL_WITH_FALLBACK_ATTEMPT: 3,
+  // The primary thumbnail image failed to load and caused a fallback to the
+  // secondary thumbnail.
+  NTP_THUMBNAIL_FALLBACK: 4
 };
 
 /**
  * Parses query parameters from Location.
  * @param {string} location The URL to generate the CSS url for.
  * @return {Object} Dictionary containing name value pairs for URL.
  */
 function parseQueryParams(location) {
   var params = Object.create(null);
   var query = location.search.substring(1);
@@ skipping 104 matching lines @@
       return;
   }
   if (/^javascript:/i.test(data.url) ||
       /^javascript:/i.test(data.thumbnailUrl) ||
       /^javascript:/i.test(data.thumbnailUrl2))
     return;
   if (data.direction)
     document.body.dir = data.direction;
   fill(params, data);
 }